GNU bug report logs - #18777
[PATCH] dfa: improvement for checking of multibyte character boundary

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Eric Blake <eblake <at> redhat.com>, 18777 <at> debbugs.gnu.org
Subject: bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary
Date: Tue, 16 Dec 2014 16:06:54 -0800

Norihiro Tanaka wrote:
> However, first it is no longer portable after
> remove it.

"portable"?  This issue is independent of platform, surely.  By "portable" did 
you mean "robust in the presence of future changes?

> Second if it is compiled with GCC 4.3 or later, the function
> is inlined by and "WCP == NULL &&" will be pruned.

True, but I wasn't worried so much about that.  I was worried about the case 
where WCP != NULL: there, the inlined function will be slower because it won't 
use the faster approach of checking always_character_boundary[*p]: it'll always 
use the much-slower loop.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.