GNU bug report logs - #18777
[PATCH] dfa: improvement for checking of multibyte character boundary

Previous Next

Full log

Message #41 received at 18777 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Eric Blake <eblake <at> redhat.com>, 18777 <at> debbugs.gnu.org
Subject: Re: bug#18777: [PATCH] dfa: improvement for checking of multibyte
 character boundary
Date: Wed, 17 Dec 2014 08:22:20 +0900

On Tue, 16 Dec 2014 09:12:21 -0800
Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> 
> This part of the patch does too much work, as the caller inspects *WCP
> only when skip_remains_mb returns a value not equal to p.  So there's
> no need for the "wcp == NULL &&" test in the patch. Instead, the
> documented API can change, saying that *WCP is assigned to only if WCP
> is non-NULL and the result is greater than p.

Thanks, you are right.  However, first it is no longer portable after
remove it.  Second if it is compiled with GCC 4.3 or later, the function
is inlined by and "WCP == NULL &&" will be pruned.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.