GNU bug report logs - #18632
24.3.94; image-dired fail when `image-dired-dir' doesn't exist

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#18632: 24.3.94;
 image-dired fail when `image-dired-dir' doesn't exist
Date: Sun, 05 Oct 2014 16:12:30 +0200

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> If `image-dired-dir' doesn't exists, image-dired fail with 
> something like "could not resize image" with no indications on what is happening.
> IOW image-dired should create its directory when this one doesn't
> exists, or at least send a helpful message to notify user he have first
> to create manually this directory.

diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 114deab..01f88c2 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1800,7 +1800,8 @@ should feel snappy enough.
 
 If optional argument ORIGINAL-SIZE is non-nil, display image in its
 original size."
-  (let ((new-file (expand-file-name image-dired-temp-image-file))
+  (let ((new-file (expand-file-name image-dired-temp-image-file
+                                    (image-dired-dir)))
         width height command ret
         (image-type 'jpeg))
     (setq file (expand-file-name file))

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.