GNU bug report logs - #18633
24.3; `customize-save-customized' should be handled as a transaction

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18633 in the body.
You can then email your comments to 18633 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matúš Goljer <matus.goljer <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; `customize-save-customized' should be handled as a transaction
Date: Sun, 05 Oct 2014 16:18:00 +0200

If `customize-save-customized' is issued (through M-x or any other way,
such as C-x C-s in customize buffer), and during the run of the function
"exit" is called (e.g. using C-g), the routine writes garbage into the
`custom-set-variables' form in `custom-file'.

We should first construct the form in a temporary buffer and then write
it at once into the output file.  Another (simpler) solution is to use
`atomic-change-group' from subr.el

Had I not kept the file under git, I would've lost most of my settings.
It seems like a good idea to handle a critical operation like this
atomically.

Cheers.

-- 
Best regards,
  Matúš Goljer

Message #8 received at 18633 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matúš Goljer <matus.goljer <at> gmail.com>
Cc: 18633 <at> debbugs.gnu.org
Subject: Re: bug#18633: 24.3; `customize-save-customized' should be handled
 as a transaction
Date: Fri, 04 Dec 2020 12:15:47 +0100

Matúš Goljer <matus.goljer <at> gmail.com> writes:

> We should first construct the form in a temporary buffer and then write
> it at once into the output file.  Another (simpler) solution is to use
> `atomic-change-group' from subr.el

(This bug report unfortunately got no response at the time.)

I've now done the latter in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.