GNU bug report logs - #18603
eww fails to recognize URIs with IPv6 addresses in them

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18603: closed (eww fails to recognize URIs with IPv6
 addresses in them )
Date: Sun, 02 Nov 2014 21:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 02 Nov 2014 16:41:20 -0500
with message-id <87a949cmbj.fsf <at> lifelogs.com>
and subject line Re: bug#18603: eww fails to recognize URIs with IPv6 addresses in them
has caused the debbugs.gnu.org bug report #18603,
regarding eww fails to recognize URIs with IPv6 addresses in them 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18603: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18603
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: eww fails to recognize URIs with IPv6 addresses in them 
Date: Thu, 02 Oct 2014 09:37:49 +0000

[Message part 3 (text/plain, inline)]

Package:  emacs
Severity: normal

	As of 94758757dfd5, the ‘eww’ function uses the presence of a
	full stop character in its ‘url’ argument as one of the
	conditions to consider the value a URI proper (as opposed to:
	keywords to pass to the search engine, as per
	eww-search-prefix.)

	This, however, fails, as IPv6 addresses are colon-delimited, and
	thus IPv6-based URLs do not usually contain any full stop
	characters (as in: https://[::1]/.)

	Please thus consider the trivial patch MIMEd, which makes EWW
	use ‘[.:]’ (was: ‘\.’) as the respective RE.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 4 (text/diff, inline)]

--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -154,7 +154,7 @@ defun eww (url)
         (t
          (if (and (= (length (split-string url)) 1)
                  (or (and (not (string-match-p "\\`[\"\'].*[\"\']\\'" url))
-                          (> (length (split-string url "\\.")) 1))
+                          (> (length (split-string url "[.:]")) 1))
                      (string-match eww-local-regex url)))
              (progn
                (unless (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url)

[Message part 5 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18603-done <at> debbugs.gnu.org
Subject: Re: bug#18603: eww fails to recognize URIs with IPv6 addresses in them
Date: Sun, 02 Nov 2014 16:41:20 -0500

On Thu, 02 Oct 2014 09:37:49 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 
IS> 	Please thus consider the trivial patch MIMEd, which makes EWW
IS> 	use ‘[.:]’ (was: ‘\.’) as the respective RE.

This works and looks good, so I applied it.  Closing.  Thanks!

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.