GNU bug report logs - #18603
eww fails to recognize URIs with IPv6 addresses in them

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18603 in the body.
You can then email your comments to 18603 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: eww fails to recognize URIs with IPv6 addresses in them 
Date: Thu, 02 Oct 2014 09:37:49 +0000

[Message part 1 (text/plain, inline)]

Package:  emacs
Severity: normal

	As of 94758757dfd5, the ‘eww’ function uses the presence of a
	full stop character in its ‘url’ argument as one of the
	conditions to consider the value a URI proper (as opposed to:
	keywords to pass to the search engine, as per
	eww-search-prefix.)

	This, however, fails, as IPv6 addresses are colon-delimited, and
	thus IPv6-based URLs do not usually contain any full stop
	characters (as in: https://[::1]/.)

	Please thus consider the trivial patch MIMEd, which makes EWW
	use ‘[.:]’ (was: ‘\.’) as the respective RE.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 2 (text/diff, inline)]

--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -154,7 +154,7 @@ defun eww (url)
         (t
          (if (and (= (length (split-string url)) 1)
                  (or (and (not (string-match-p "\\`[\"\'].*[\"\']\\'" url))
-                          (> (length (split-string url "\\.")) 1))
+                          (> (length (split-string url "[.:]")) 1))
                      (string-match eww-local-regex url)))
              (progn
                (unless (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url)

Message #10 received at 18603-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18603-done <at> debbugs.gnu.org
Subject: Re: bug#18603: eww fails to recognize URIs with IPv6 addresses in them
Date: Sun, 02 Nov 2014 16:41:20 -0500

On Thu, 02 Oct 2014 09:37:49 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 
IS> 	Please thus consider the trivial patch MIMEd, which makes EWW
IS> 	use ‘[.:]’ (was: ‘\.’) as the respective RE.

This works and looks good, so I applied it.  Closing.  Thanks!

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.