GNU bug report logs - #1858
cleanup: POLL_FOR_INPUT

Previous Next

Full log

View this message in rfc822 format

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1858 <at> debbugs.gnu.org
Subject: bug#1858: cleanup: POLL_FOR_INPUT
Date: Sun, 10 Jul 2011 16:52:14 +0200

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...

keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:

> #ifdef HAVE_WINDOW_SYSTEM

> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.