GNU bug report logs - #1858
cleanup: POLL_FOR_INPUT

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1858 in the body.
You can then email your comments to 1858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: cleanup: POLL_FOR_INPUT
Date: Sun, 11 Jan 2009 09:30:27 -0800 (PST)

POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
exactly the same way:


keyboard.c:
/* If we support a window system, turn on the code to poll periodically
   to detect C-g.  It isn't actually used when doing interrupt input.
   */
#ifdef HAVE_WINDOW_SYSTEM
#define POLL_FOR_INPUT
#endif


process.c:
/* If we support a window system, turn on the code to poll periodically
   to detect C-g.  It isn't actually used when doing interrupt input.
   */
#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
#define POLL_FOR_INPUT
#endif

keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
before POLL_FOR_INPUT is defined...

The above is messy...

Message #8 received at 1858 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1858 <at> debbugs.gnu.org
Subject: Re: cleanup: POLL_FOR_INPUT
Date: Sun, 10 Jul 2011 16:52:14 +0200

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
>    to detect C-g.  It isn't actually used when doing interrupt input.
>    */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...

keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:

> #ifdef HAVE_WINDOW_SYSTEM

> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #11 received at 1858 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1858 <at> debbugs.gnu.org
Subject: Re: cleanup: POLL_FOR_INPUT
Date: Sat, 16 Jul 2011 20:31:30 +0200

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

>> #ifdef HAVE_WINDOW_SYSTEM
>
>> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
>
> Is this a bug, or are the two .c files supposed to have different
> conditions for when to switch POLL_FOR_INPUT on?

Looking at the changelogs, the version in keyboard.c was newer, so I
used the 

#if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)

in process.h, too.  I 

Somebody can probably correct this if this is wrong.  :-)

However, I have no idea what USE_ASYNC_EVENTS refer to, since it isn't
mention anywhere else in any of the files.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.