GNU bug report logs - #18562
24.4.50; More typos in recent w32term.h change

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Thu, 25 Sep 2014 23:32:01 UTC

Severity: normal

Found in version 24.4.50

Fixed in version 25.1

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 18562 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 18562 <at> debbugs.gnu.org
Subject: Re: bug#18562: 24.4.50; More typos in recent w32term.h change
Date: Fri, 26 Sep 2014 10:07:26 +0300
> Date: Thu, 25 Sep 2014 19:13:41 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> I think the following patch should be applied in order to (a) take 
> account of the fact that USE_STACK_LISP_OBJECTS is always defined in the 
> current lisp.h; and (b) exclude the 64-bit case on Cygwin.
> 
> === modified file 'src/w32term.h'
> --- src/w32term.h       2014-09-25 17:28:48 +0000
> +++ src/w32term.h       2014-09-25 23:05:35 +0000
> @@ -30,7 +30,7 @@
>      re-align the stack at function entry.  Further details about this
>      can be found in http://www.peterstock.co.uk/games/mingw_sse/.  */
>   #ifdef __GNUC__
> -# if defined USE_STACK_LISP_OBJECTS && !defined _W64   \
> +# if USE_STACK_LISP_OBJECTS && !defined _W64 && !defined __x86_64__    \
>     && __GNUC__ + (__GNUC_MINOR__ > 1) >= 5
>   #  define ALIGN_STACK __attribute__((force_align_arg_pointer))
>   # else

Thanks, committed.




This bug report was last modified 10 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.