GNU bug report logs - #18562
24.4.50; More typos in recent w32term.h change

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18562 in the body.
You can then email your comments to 18562 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; More typos in recent w32term.h change
Date: Thu, 25 Sep 2014 19:13:41 -0400

I think the following patch should be applied in order to (a) take 
account of the fact that USE_STACK_LISP_OBJECTS is always defined in the 
current lisp.h; and (b) exclude the 64-bit case on Cygwin.

=== modified file 'src/w32term.h'
--- src/w32term.h       2014-09-25 17:28:48 +0000
+++ src/w32term.h       2014-09-25 23:05:35 +0000
@@ -30,7 +30,7 @@
    re-align the stack at function entry.  Further details about this
    can be found in http://www.peterstock.co.uk/games/mingw_sse/.  */
 #ifdef __GNUC__
-# if defined USE_STACK_LISP_OBJECTS && !defined _W64   \
+# if USE_STACK_LISP_OBJECTS && !defined _W64 && !defined __x86_64__    \
   && __GNUC__ + (__GNUC_MINOR__ > 1) >= 5
 #  define ALIGN_STACK __attribute__((force_align_arg_pointer))
 # else


Ken

In GNU Emacs 24.4.50.5 (i686-pc-cygwin)
 of 2014-09-25 on moufang
Repository revision: 117952 juri <at> jurta.org-20140925205558-frm6u28shvcuml9a
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --with-w32 --with-file-notification=no
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3''

Configured features:
XPM JPEG TIFF GIF PNG IMAGEMAGICK DBUS ACL GNUTLS LIBXML2 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
M-x r e p o r t <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind w32
multi-tty emacs)

Memory information:
((conses 8 78071 6361)
 (symbols 24 17816 0)
 (miscs 20 43 148)
 (strings 16 12654 3411)
 (string-bytes 1 313507)
 (vectors 8 10025)
 (vector-slots 4 390451 2262)
 (floats 8 70 302)
 (intervals 28 202 30)
 (buffers 520 12))

Message #8 received at 18562 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 18562 <at> debbugs.gnu.org
Subject: Re: bug#18562: 24.4.50; More typos in recent w32term.h change
Date: Fri, 26 Sep 2014 10:07:26 +0300

> Date: Thu, 25 Sep 2014 19:13:41 -0400
> From: Ken Brown <kbrown <at> cornell.edu>
> 
> I think the following patch should be applied in order to (a) take 
> account of the fact that USE_STACK_LISP_OBJECTS is always defined in the 
> current lisp.h; and (b) exclude the 64-bit case on Cygwin.
> 
> === modified file 'src/w32term.h'
> --- src/w32term.h       2014-09-25 17:28:48 +0000
> +++ src/w32term.h       2014-09-25 23:05:35 +0000
> @@ -30,7 +30,7 @@
>      re-align the stack at function entry.  Further details about this
>      can be found in http://www.peterstock.co.uk/games/mingw_sse/.  */
>   #ifdef __GNUC__
> -# if defined USE_STACK_LISP_OBJECTS && !defined _W64   \
> +# if USE_STACK_LISP_OBJECTS && !defined _W64 && !defined __x86_64__    \
>     && __GNUC__ + (__GNUC_MINOR__ > 1) >= 5
>   #  define ALIGN_STACK __attribute__((force_align_arg_pointer))
>   # else

Thanks, committed.

Message #13 received at 18562-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18562-done <at> debbugs.gnu.org
Subject: Re: bug#18562: 24.4.50; More typos in recent w32term.h change
Date: Fri, 26 Sep 2014 08:17:53 -0400

Version: 24.5

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.