GNU bug report logs - #18496
24.4.50; RefTeX modes should use font-lock-face instead of face

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18496: closed (24.4.50; RefTeX modes should use
 font-lock-face instead of face)
Date: Sun, 21 Sep 2014 09:37:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 21 Sep 2014 11:36:08 +0200
with message-id <874mw1mi2f.fsf <at> thinkpad-t440p.tsdh.org>
and subject line Re: bug#18496: 24.4.50; RefTeX modes should use font-lock-face instead of face
has caused the debbugs.gnu.org bug report #18496,
regarding 24.4.50; RefTeX modes should use font-lock-face instead of face
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18496: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18496
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sebastian Wiesner <swiesner <at> lunaryorn.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; RefTeX modes should use font-lock-face instead of face
Date: Thu, 18 Sep 2014 11:32:37 +0200

The following RefTeX modes should use the font-lock-face text property
instead of face:

- reftex-toc-mode
- reftex-select-label-mode
- reftex-select-bib-mode

Using face directly breaks fontification if special minor modes are
enabled that add extra fontification.

Originally reported for rainbow-delimiters, see
https://github.com/jlr/rainbow-delimiters/issues/31 and
https://github.com/jlr/rainbow-delimiters/pull/38

On a related note, it seems as if these modes should probably inherit
special-mode, shouldn't they?

[Message part 3 (message/rfc822, inline)]

From: Tassilo Horn <tsdh <at> gnu.org>
To: Sebastian Wiesner <swiesner <at> lunaryorn.com>
Cc: 18496-done <at> debbugs.gnu.org
Subject: Re: bug#18496: 24.4.50;
 RefTeX modes should use font-lock-face instead of face
Date: Sun, 21 Sep 2014 11:36:08 +0200

Sebastian Wiesner <swiesner <at> lunaryorn.com> writes:

> The following RefTeX modes should use the font-lock-face text property
> instead of face:
>
> - reftex-toc-mode
> - reftex-select-label-mode
> - reftex-select-bib-mode
>
> Using face directly breaks fontification if special minor modes are
> enabled that add extra fontification.

Indeed, thanks for the hint.

> On a related note, it seems as if these modes should probably inherit
> special-mode, shouldn't they?

Yes, right.

I've done both in revision 117907.

Thanks,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.