GNU bug report logs - #18481
vc/vc-git.el: use `with-demoted-errors' instead of `ignore-errors'.

Previous Next

Package: emacs;

Reported by: Emilio Lopes <eclig <at> gmx.net>

Date: Mon, 15 Sep 2014 13:43:01 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emilio Lopes <eclig <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: vc/vc-git.el: use `with-demoted-errors' instead of `ignore-errors'.
Date: Mon, 15 Sep 2014 15:42:25 +0200
cf. http://lists.gnu.org/archive/html/bug-gnu-emacs/2014-09/msg00394.html

--- lisp/ChangeLog    2014-09-15 00:20:21 +0000
+++ lisp/ChangeLog    2014-09-15 13:36:10 +0000
@@ -1,3 +1,14 @@
+2014-09-15  Emilio C. Lopes  <eclig <at> gmx.net>
+
+    * vc/vc-git.el (vc-git-registered): use `with-demoted-errors'
+    instead of `ignore-errors' so that the user is informed if
+    something unexpected happens.
+
 2014-09-15  Glenn Morris  <rgm <at> gnu.org>

     * image.el (image-multi-frame-p): Fix thinko - do not force

=== modified file 'lisp/vc/vc-git.el'
--- lisp/vc/vc-git.el    2014-09-04 16:34:45 +0000
+++ lisp/vc/vc-git.el    2014-09-15 13:36:10 +0000
@@ -185,7 +185,7 @@
                ;; path specs.
                ;; See also: http://marc.info/?l=git&m=125787684318129&w=2
                (name (file-relative-name file dir))
-               (str (ignore-errors
+               (str (with-demoted-errors "Error: %S"
                       (cd dir)
                       (vc-git--out-ok "ls-files" "-c" "-z" "--" name)
                       ;; If result is empty, use ls-tree to check for deleted




This bug report was last modified 4 years and 278 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.