GNU bug report logs - #18257
C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.

Previous Next

Full log

View this message in rfc822 format

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.
Date: Thu, 26 Jan 2017 17:55:50 +0900

[Message part 1 (text/plain, inline)]

On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote:
> Sorry, that is my fault.  How about this patch?

I'm sorry again.  This is the right one:

* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys keys (bug#18257).

[Message part 2 (text/x-patch, inline)]

--- gnus-art.el~	2017-01-25 22:07:29.825734200 +0000
+++ gnus-art.el	2017-01-26 08:54:39.004906700 +0000
@@ -6846,17 +6846,21 @@
   (let ((keymap (copy-keymap gnus-article-mode-map))
 	(map (copy-keymap gnus-article-send-map))
 	(sumkeys (where-is-internal 'gnus-article-read-summary-keys))
+	(summap (make-sparse-keymap))
 	parent agent draft)
     (define-key keymap "S" map)
     (define-key map [t] nil)
+    (define-key summap [t] 'undefined)
     (with-current-buffer gnus-article-current-summary
+      (dolist (key sumkeys)
+	(define-key summap key (key-binding key (current-local-map))))
       (set-keymap-parent
        keymap
        (if (setq parent (keymap-parent gnus-article-mode-map))
 	   (prog1
 	       (setq parent (copy-keymap parent))
-	     (set-keymap-parent parent (current-local-map)))
-	 (current-local-map)))
+	     (set-keymap-parent parent summap))
+	 summap))
       (set-keymap-parent map (key-binding "S"))
       (let (key def gnus-pick-mode)
 	(while sumkeys

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.