GNU bug report logs - #18257
C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18257 in the body.
You can then email your comments to 18257 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.
Date: Wed, 13 Aug 2014 12:48:22 +0200

Hello,

Recipe:

1. open gnus (e.g. "emacs -Q -f gnus-no-server")
2. open a group and an article in it
3. hit C-x o to select the article window.
4. hit C-h b to show the available bindings
4bis. in the list, "C-c C-f" is mentionned (at line 201 here)
5. hit C-c C-f

Result: "C-c C-f is undefined"
Expected result: prepare a buffer for forwarding the selected message.

Gnus v5.13
GNU Emacs 24.3.92.2 (i686-pc-linux-gnu, GTK+ Version 2.24.20)
 of 2014-08-08 on LDLC-portable

Message #8 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
Cc: 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Wed, 25 Jan 2017 20:40:52 +0100

Nicolas Richard <theonewiththeevillook <at> yahoo.fr> writes:

> 1. open gnus (e.g. "emacs -Q -f gnus-no-server")
> 2. open a group and an article in it
> 3. hit C-x o to select the article window.
> 4. hit C-h b to show the available bindings
> 4bis. in the list, "C-c C-f" is mentionned (at line 201 here)
> 5. hit C-c C-f
>
> Result: "C-c C-f is undefined"
> Expected result: prepare a buffer for forwarding the selected message.

Fixed on the Emacs trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
Cc: 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Wed, 25 Jan 2017 22:55:15 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Nicolas Richard <theonewiththeevillook <at> yahoo.fr> writes:
>
>> 1. open gnus (e.g. "emacs -Q -f gnus-no-server")
>> 2. open a group and an article in it
>> 3. hit C-x o to select the article window.
>> 4. hit C-h b to show the available bindings
>> 4bis. in the list, "C-c C-f" is mentionned (at line 201 here)
>> 5. hit C-c C-f
>>
>> Result: "C-c C-f is undefined"
>> Expected result: prepare a buffer for forwarding the selected message.
>
> Fixed on the Emacs trunk now.

Just binding "C-c" in the article buffer (like other prefixed) led to
problems in other parts of Emacs somehow, so I've reverted that patch
and will have to implement it a different way.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Thu, 26 Jan 2017 17:10:51 +0900

[Message part 1 (text/plain, inline)]

On Wed, 25 Jan 2017 22:55:15 +0100, Lars Ingebrigtsen wrote:
> Just binding "C-c" in the article buffer (like other prefixed) led to
> problems in other parts of Emacs somehow, so I've reverted that patch
> and will have to implement it a different way.

Sorry, that is my fault.  How about this patch?

* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys.

[Message part 2 (text/x-patch, inline)]

--- gnus-art.el~	2017-01-25 22:07:29.825734200 +0000
+++ gnus-art.el	2017-01-26 08:10:00.743177500 +0000
@@ -6846,16 +6846,20 @@
   (let ((keymap (copy-keymap gnus-article-mode-map))
 	(map (copy-keymap gnus-article-send-map))
 	(sumkeys (where-is-internal 'gnus-article-read-summary-keys))
+	(summap (make-sparse-keymap))
 	parent agent draft)
     (define-key keymap "S" map)
     (define-key map [t] nil)
+    (define-key summap [t] 'undefined)
     (with-current-buffer gnus-article-current-summary
+      (dolist (key sumkeys)
+	(define-key summap key (key-binding key (current-local-map))))
       (set-keymap-parent
        keymap
        (if (setq parent (keymap-parent gnus-article-mode-map))
 	   (prog1
 	       (setq parent (copy-keymap parent))
-	     (set-keymap-parent parent (current-local-map)))
+	     (set-keymap-parent parent summap))
 	 (current-local-map)))
       (set-keymap-parent map (key-binding "S"))
       (let (key def gnus-pick-mode)

Message #27 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Thu, 26 Jan 2017 17:55:50 +0900

[Message part 1 (text/plain, inline)]

On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote:
> Sorry, that is my fault.  How about this patch?

I'm sorry again.  This is the right one:

* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys keys (bug#18257).

[Message part 2 (text/x-patch, inline)]

--- gnus-art.el~	2017-01-25 22:07:29.825734200 +0000
+++ gnus-art.el	2017-01-26 08:54:39.004906700 +0000
@@ -6846,17 +6846,21 @@
   (let ((keymap (copy-keymap gnus-article-mode-map))
 	(map (copy-keymap gnus-article-send-map))
 	(sumkeys (where-is-internal 'gnus-article-read-summary-keys))
+	(summap (make-sparse-keymap))
 	parent agent draft)
     (define-key keymap "S" map)
     (define-key map [t] nil)
+    (define-key summap [t] 'undefined)
     (with-current-buffer gnus-article-current-summary
+      (dolist (key sumkeys)
+	(define-key summap key (key-binding key (current-local-map))))
       (set-keymap-parent
        keymap
        (if (setq parent (keymap-parent gnus-article-mode-map))
 	   (prog1
 	       (setq parent (copy-keymap parent))
-	     (set-keymap-parent parent (current-local-map)))
-	 (current-local-map)))
+	     (set-keymap-parent parent summap))
+	 summap))
       (set-keymap-parent map (key-binding "S"))
       (let (key def gnus-pick-mode)
 	(while sumkeys

Message #30 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Thu, 26 Jan 2017 18:12:43 +0100

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote:
>> Sorry, that is my fault.  How about this patch?
>
> I'm sorry again.  This is the right one:
>
> * lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
> Ignore summary commands that aren't bound to
> gnus-article-read-summary-keys keys (bug#18257).

Great; can you apply it to the Emacs trunk?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #33 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Fri, 27 Jan 2017 07:44:19 +0900

On Thu, 26 Jan 2017 18:12:43 +0100, Lars Ingebrigtsen wrote:
> Great; can you apply it to the Emacs trunk?

Done.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.