GNU bug report logs - #18257
C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode.

Previous Next

Packages: gnus, emacs;

Reported by: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>

Date: Wed, 13 Aug 2014 10:49:02 UTC

Severity: normal

Tags: fixed

Done: Katsumi Yamaoka <yamaoka <at> jpl.org>

Bug is archived. No further changes may be made.

Full log


Message #24 received at 18257 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>, 18257 <at> debbugs.gnu.org
Subject: Re: bug#18257: C-h b mentions "C-c C-f" as a valid binding in
 gnus-article-mode.
Date: Thu, 26 Jan 2017 17:10:51 +0900
[Message part 1 (text/plain, inline)]
On Wed, 25 Jan 2017 22:55:15 +0100, Lars Ingebrigtsen wrote:
> Just binding "C-c" in the article buffer (like other prefixed) led to
> problems in other parts of Emacs somehow, so I've reverted that patch
> and will have to implement it a different way.

Sorry, that is my fault.  How about this patch?

* lisp/gnus/gnus-art.el (gnus-article-describe-bindings):
Ignore summary commands that aren't bound to
gnus-article-read-summary-keys.

[Message part 2 (text/x-patch, inline)]
--- gnus-art.el~	2017-01-25 22:07:29.825734200 +0000
+++ gnus-art.el	2017-01-26 08:10:00.743177500 +0000
@@ -6846,16 +6846,20 @@
   (let ((keymap (copy-keymap gnus-article-mode-map))
 	(map (copy-keymap gnus-article-send-map))
 	(sumkeys (where-is-internal 'gnus-article-read-summary-keys))
+	(summap (make-sparse-keymap))
 	parent agent draft)
     (define-key keymap "S" map)
     (define-key map [t] nil)
+    (define-key summap [t] 'undefined)
     (with-current-buffer gnus-article-current-summary
+      (dolist (key sumkeys)
+	(define-key summap key (key-binding key (current-local-map))))
       (set-keymap-parent
        keymap
        (if (setq parent (keymap-parent gnus-article-mode-map))
 	   (prog1
 	       (setq parent (copy-keymap parent))
-	     (set-keymap-parent parent (current-local-map)))
+	     (set-keymap-parent parent summap))
 	 (current-local-map)))
       (set-keymap-parent map (key-binding "S"))
       (let (key def gnus-pick-mode)

This bug report was last modified 8 years and 117 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.