GNU bug report logs - #18204
24.4.50; `ediff-file-compressed-p'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Tue, 5 Aug 2014 21:51:01 UTC

Severity: wishlist

Tags: fixed

Found in version 24.4.50

Fixed in version 26.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18204 in the body.
You can then email your comments to 18204 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18204; Package emacs. (Tue, 05 Aug 2014 21:51:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 05 Aug 2014 21:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; `ediff-file-compressed-p'
Date: Tue, 5 Aug 2014 14:49:29 -0700 (PDT)

Could be improved from this:

(defun ediff-file-compressed-p (file)
  (condition-case nil
      (require 'jka-compr)
    (error))
  (if (featurep 'jka-compr)
      (string-match (jka-compr-build-file-regexp) file)))

to this:

(defun ediff-file-compressed-p (file)
  (and (require 'jka-compr nil t)
       (string-match-p (jka-compr-build-file-regexp) file)))

Or just remove it altogether - it is used only once.

(Or provide it as a general function, outside `ediff-util'.)

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18204; Package emacs. (Sat, 30 Apr 2016 00:39:02 GMT) Full text and rfc822 format available.

Message #8 received at 18204 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 18204 <at> debbugs.gnu.org
Subject: Re: bug#18204: 24.4.50; `ediff-file-compressed-p'
Date: Sat, 30 Apr 2016 02:38:01 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> Could be improved from this:
>
> (defun ediff-file-compressed-p (file)
>   (condition-case nil
>       (require 'jka-compr)
>     (error))
>   (if (featurep 'jka-compr)
>       (string-match (jka-compr-build-file-regexp) file)))
>
> to this:
>
> (defun ediff-file-compressed-p (file)
>   (and (require 'jka-compr nil t)
>        (string-match-p (jka-compr-build-file-regexp) file)))

Probably written that way for backwards compatibility.

I've now simplified it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 30 Apr 2016 00:39:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 25.2, send any further explanations to 18204 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 30 Apr 2016 00:39:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 28 May 2016 11:24:04 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:06 GMT) Full text and rfc822 format available.
bug Marked as fixed in versions 26.1. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:06 GMT) Full text and rfc822 format available.
bug No longer marked as fixed in versions 25.2. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:06 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Jan 2017 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 231 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.