GNU bug report logs - #18203
24.4.50; `ffap-url-p' should NOT be a defsubst

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18203 in the body.
You can then email your comments to 18203 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; `ffap-url-p' should NOT be a defsubst
Date: Tue, 5 Aug 2014 13:21:34 -0700 (PDT)

There is NO reason for this to be a defsubst.  There is no reason for
users not to take advantage of this function generally.

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

Message #8 received at 18203 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 18203 <at> debbugs.gnu.org
Subject: Re: bug#18203: 24.4.50; `ffap-url-p' should NOT be a defsubst
Date: Fri, 25 Dec 2015 20:44:15 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

> There is NO reason for this to be a defsubst.  There is no reason for
> users not to take advantage of this function generally.

I changed it to a defun, but I don't know what you mean by "There is no
reason for users not to take advantage of this function generally.".
You can use a defsubst just as you would a defun.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 18203 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 18203 <at> debbugs.gnu.org
Subject: RE: bug#18203: 24.4.50; `ffap-url-p' should NOT be a defsubst
Date: Fri, 25 Dec 2015 14:44:16 -0800 (PST)

> > There is NO reason for this to be a defsubst.  There is no reason for
> > users not to take advantage of this function generally.
> 
> I changed it to a defun,

Thank you.

> but I don't know what you mean by "There is no
> reason for users not to take advantage of this function generally.".
> You can use a defsubst just as you would a defun.

No, you cannot.

If existing code invokes a defsubst and you have only the compiled
version of that code, then you have no access to the function
defined by that defsubst.  The function _does not exist_ at runtime.
You cannot advise it or debug it, and redefining it has no effect.

Taking advantage of the function _"generally"_ includes having it
available at runtime - it requires its existence _as a function_.

`defsubst's are almost a misfeature nowadays.  In any case, they
be used should rarely, and only with good justification.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.