GNU bug report logs - #18057
[PATCH] Find tail.c in srcdir, not builddir

Previous Next

Package: coreutils;

Reported by: Andreas Schwab <schwab <at> linux-m68k.org>

Date: Sat, 19 Jul 2014 15:28:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Andreas Schwab <schwab <at> linux-m68k.org>, 18057 <at> debbugs.gnu.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Wed, 23 Jul 2014 16:37:33 +0200

On 07/19/2014 05:26 PM, Andreas Schwab wrote:
> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
> index c25f354..7140871 100755
> --- a/tests/tail-2/inotify-race.sh
> +++ b/tests/tail-2/inotify-race.sh
> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>       *) skip_ "can't run gdb";;
>   esac
>
> -break_src="$abs_top_builddir/src/tail.c"
> +break_src="$abs_top_srcdir/src/tail.c"
>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>

Thanks for the patch.
However, what's wrong with $abs_top_builddir?
... given that it's successfully used in 21 other
places:

  $ git grep abs_top_builddir -- tests | wc -l
  22

Thanks & have a nice day,
Berny
This bug report was last modified 10 years and 301 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.