GNU bug report logs - #18057
[PATCH] Find tail.c in srcdir, not builddir

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18057 in the body.
You can then email your comments to 18057 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] Find tail.c in srcdir, not builddir
Date: Sat, 19 Jul 2014 17:26:46 +0200

diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
index c25f354..7140871 100755
--- a/tests/tail-2/inotify-race.sh
+++ b/tests/tail-2/inotify-race.sh
@@ -37,7 +37,7 @@ case $(cat gdb.out) in
     *) skip_ "can't run gdb";;
 esac
 
-break_src="$abs_top_builddir/src/tail.c"
+break_src="$abs_top_srcdir/src/tail.c"
 break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
 break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
 
-- 
2.0.2


-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #8 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Andreas Schwab <schwab <at> linux-m68k.org>, 18057 <at> debbugs.gnu.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Wed, 23 Jul 2014 16:37:33 +0200

On 07/19/2014 05:26 PM, Andreas Schwab wrote:
> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
> index c25f354..7140871 100755
> --- a/tests/tail-2/inotify-race.sh
> +++ b/tests/tail-2/inotify-race.sh
> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>       *) skip_ "can't run gdb";;
>   esac
>
> -break_src="$abs_top_builddir/src/tail.c"
> +break_src="$abs_top_srcdir/src/tail.c"
>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>

Thanks for the patch.
However, what's wrong with $abs_top_builddir?
... given that it's successfully used in 21 other
places:

  $ git grep abs_top_builddir -- tests | wc -l
  22

Thanks & have a nice day,
Berny

Message #11 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 18057 <at> debbugs.gnu.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Wed, 23 Jul 2014 18:48:30 +0200

Bernhard Voelker <mail <at> bernhard-voelker.de> writes:

> On 07/19/2014 05:26 PM, Andreas Schwab wrote:
>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
>> index c25f354..7140871 100755
>> --- a/tests/tail-2/inotify-race.sh
>> +++ b/tests/tail-2/inotify-race.sh
>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>>       *) skip_ "can't run gdb";;
>>   esac
>>
>> -break_src="$abs_top_builddir/src/tail.c"
>> +break_src="$abs_top_srcdir/src/tail.c"
>>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>>
>
> Thanks for the patch.
> However, what's wrong with $abs_top_builddir?

Is that a serious question?

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #14 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>,
 Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 18057 <at> debbugs.gnu.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Wed, 23 Jul 2014 11:14:31 -0600

[Message part 1 (text/plain, inline)]

On 07/23/2014 10:48 AM, Andreas Schwab wrote:
> Bernhard Voelker <mail <at> bernhard-voelker.de> writes:
> 
>> On 07/19/2014 05:26 PM, Andreas Schwab wrote:
>>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
>>> index c25f354..7140871 100755
>>> --- a/tests/tail-2/inotify-race.sh
>>> +++ b/tests/tail-2/inotify-race.sh
>>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>>>       *) skip_ "can't run gdb";;
>>>   esac
>>>
>>> -break_src="$abs_top_builddir/src/tail.c"
>>> +break_src="$abs_top_srcdir/src/tail.c"
>>>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>>>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>>>
>>
>> Thanks for the patch.
>> However, what's wrong with $abs_top_builddir?
> 
> Is that a serious question?

That's where a good commit message would have spared some time.  If you
had mentioned something like this in the commit message:

tail.c lives in srcdir; for users that test in-tree, this happens to be
the same as builddir.  But this is not true for a VPATH build, and was
breaking 'make check' with the following error message:
....

then it could have prevented this back-and-forth.  The patch looks
correct and necessary to me, but it is always better to give a
maintainer zero excuse for not applying a patch by giving them full
justification up front instead of making them figure out on their own
what you already learned while writing the patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 18057 <at> debbugs.gnu.org, Bernhard Voelker <mail <at> bernhard-voelker.de>
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Sat, 26 Jul 2014 21:54:22 +0100

On 07/23/2014 05:48 PM, Andreas Schwab wrote:
> Bernhard Voelker <mail <at> bernhard-voelker.de> writes:
> 
>> On 07/19/2014 05:26 PM, Andreas Schwab wrote:
>>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
>>> index c25f354..7140871 100755
>>> --- a/tests/tail-2/inotify-race.sh
>>> +++ b/tests/tail-2/inotify-race.sh
>>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>>>       *) skip_ "can't run gdb";;
>>>   esac
>>>
>>> -break_src="$abs_top_builddir/src/tail.c"
>>> +break_src="$abs_top_srcdir/src/tail.c"
>>>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>>>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>>>
>>
>> Thanks for the patch.
>> However, what's wrong with $abs_top_builddir?
> 
> Is that a serious question?

Please be constructive.

Bernhard was referring to the other instances with VPATH issues,
that may only be passing now accidentally.

I.E.: git grep "abs_top_builddir}\?/"

thanks,
Pádraig.

Message #20 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 18057 <at> debbugs.gnu.org, Bernhard Voelker <mail <at> bernhard-voelker.de>
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Sat, 26 Jul 2014 23:29:10 +0200

Pádraig Brady <P <at> draigBrady.com> writes:

> Bernhard was referring to the other instances with VPATH issues,
> that may only be passing now accidentally.

Please don't mix unrelated issues.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #25 received at 18057-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Andreas Schwab <schwab <at> linux-m68k.org>, 18057-done <at> debbugs.gnu.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Fri, 01 Aug 2014 12:52:03 -0700

Andreas Schwab wrote:
> -break_src="$abs_top_builddir/src/tail.c"
> +break_src="$abs_top_srcdir/src/tail.c"

Thanks; I installed that.

Message #28 received at 18057 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 18057 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu, schwab <at> linux-m68k.org
Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Fri, 01 Aug 2014 22:17:39 +0100

On 08/01/2014 08:52 PM, Paul Eggert wrote:
> Andreas Schwab wrote:
>> -break_src="$abs_top_builddir/src/tail.c"
>> +break_src="$abs_top_srcdir/src/tail.c"
> 
> Thanks; I installed that.

Looks good thanks.
I thought there might also be an issue with at least
"$abs_top_builddir/src/coreutils.h", but that's generated
in the builddir so is fine.

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.