GNU bug report logs - #18057
[PATCH] Find tail.c in srcdir, not builddir

Previous Next

Full log

View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 18057 <at> debbugs.gnu.org, Bernhard Voelker <mail <at> bernhard-voelker.de>
Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir
Date: Sat, 26 Jul 2014 21:54:22 +0100

On 07/23/2014 05:48 PM, Andreas Schwab wrote:
> Bernhard Voelker <mail <at> bernhard-voelker.de> writes:
> 
>> On 07/19/2014 05:26 PM, Andreas Schwab wrote:
>>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh
>>> index c25f354..7140871 100755
>>> --- a/tests/tail-2/inotify-race.sh
>>> +++ b/tests/tail-2/inotify-race.sh
>>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in
>>>       *) skip_ "can't run gdb";;
>>>   esac
>>>
>>> -break_src="$abs_top_builddir/src/tail.c"
>>> +break_src="$abs_top_srcdir/src/tail.c"
>>>   break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_
>>>   break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_
>>>
>>
>> Thanks for the patch.
>> However, what's wrong with $abs_top_builddir?
> 
> Is that a serious question?

Please be constructive.

Bernhard was referring to the other instances with VPATH issues,
that may only be passing now accidentally.

I.E.: git grep "abs_top_builddir}\?/"

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.