GNU bug report logs - #17914
23.3;92: eww-download-callback

Previous Next

Package: emacs;

Reported by: Charles Rendleman <carendle <at> gmail.com>

Date: Thu, 3 Jul 2014 15:42:02 UTC

Severity: normal

Tags: fixed

Merged with 18007

Found in version 24.3.92

Fixed in version 25.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17914 in the body.
You can then email your comments to 17914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17914; Package emacs. (Thu, 03 Jul 2014 15:42:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Charles Rendleman <carendle <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 03 Jul 2014 15:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles Rendleman <carendle <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.3;92: eww-download-callback
Date: Thu, 3 Jul 2014 11:41:08 -0400

[Message part 1 (text/plain, inline)]
eww-download-callback should remove the HTTP header before saving the file
after a download.

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 02fc575..cff85a5 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1075,7 +1075,9 @@ Differences in #targets are ignored."
            (path (car (url-path-and-query obj)))
            (file (eww-make-unique-file-name (file-name-nondirectory path)
                                            eww-download-directory)))
-      (write-file file)
+      (goto-char 0)
+      (re-search-forward "\r?\n\r?\n")
+      (write-region (point) (point-max) file)
       (message "Saved %s" file))))

 (defun eww-make-unique-file-name (file directory)

[Message part 2 (text/html, inline)]
Merged 17914 18007. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 12 Jul 2014 23:00:03 GMT) Full text and rfc822 format available.
bug No longer marked as found in versions 23.3. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 12 Jul 2014 23:10:02 GMT) Full text and rfc822 format available.
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 10 Nov 2014 20:57:03 GMT) Full text and rfc822 format available.
bug marked as fixed in version 25.1, send any further explanations to 18007 <at> debbugs.gnu.org and Charles Rendleman <carendle <at> gmail.com> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 10 Nov 2014 20:57:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 09 Dec 2014 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 196 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.