GNU bug report logs - #17705
[PATCH] lisp/help.el (where-is): don't recreate completing-read's functionality for defaults

Previous Next

Package: emacs;

Reported by: Cameron Desautels <camdez <at> gmail.com>

Date: Thu, 5 Jun 2014 18:09:01 UTC

Severity: minor

Tags: patch

Merged with 20390

Found in version 24.5

Fixed in version 25.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Cameron Desautels <camdez <at> gmail.com>
To: 17705 <at> debbugs.gnu.org
Subject: bug#17705: [PATCH] lisp/help.el (where-is): don't recreate completing-read's functionality for defaults
Date: Thu, 5 Jun 2014 13:08:02 -0500

[Message part 1 (text/plain, inline)]
`where-is` was looking for empty string return values from
`completing-read` and swapping in a default value in that
case. Updated now to use the default-handling mechanism provided by
`completing-read`, rather than recreating it.

This also provides a bit of extra capability because now the user can
insert the default value into the minibuffer (for modification) via
`next-history-element` (so-called "future history", described in the
elisp manual).

-- 
Cameron Desautels <camdez <at> gmail.com>

[0001-lisp-help.el-where-is-don-t-recreate-completing-read.patch (application/octet-stream, attachment)]
This bug report was last modified 10 years and 37 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.