GNU bug report logs - #17705
[PATCH] lisp/help.el (where-is): don't recreate completing-read's functionality for defaults

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17705 in the body.
You can then email your comments to 17705 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cameron Desautels <camdez <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] lisp/help.el (where-is): don't recreate completing-read's
 functionality for defaults
Date: Thu, 5 Jun 2014 13:08:02 -0500

[Message part 1 (text/plain, inline)]

`where-is` was looking for empty string return values from
`completing-read` and swapping in a default value in that
case. Updated now to use the default-handling mechanism provided by
`completing-read`, rather than recreating it.

This also provides a bit of extra capability because now the user can
insert the default value into the minibuffer (for modification) via
`next-history-element` (so-called "future history", described in the
elisp manual).

-- 
Cameron Desautels <camdez <at> gmail.com>

[0001-lisp-help.el-where-is-don-t-recreate-completing-read.patch (application/octet-stream, attachment)]

Message #10 received at 17705-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Cameron Desautels <camdez <at> gmail.com>
Cc: 17705-done <at> debbugs.gnu.org
Subject: Re: bug#17705: [PATCH] lisp/help.el (where-is): don't recreate
 completing-read's functionality for defaults
Date: Wed, 11 Jun 2014 22:21:00 -0400

> `where-is` was looking for empty string return values from
> `completing-read` and swapping in a default value in that
> case. Updated now to use the default-handling mechanism provided by
> `completing-read`, rather than recreating it.

Thank you, installed.
Note that we now have many small contributions from you, adding up to
a non-trivial amount of code, so we won't be able to accept further
patches from you without some copyright paperwork.
If you intend to submit more patches (which I hope you do), please fill
the form below and send it to the FSF as instructed so they can send you
the appropriate paperwork to sign.


        Stefan


Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.