GNU bug report logs - #17668
[PATCH] build: be more specific about .git directory before enabling warnings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17668: closed ([PATCH] build: be more specific about .git
 directory before enabling warnings)
Date: Mon, 02 Jun 2014 17:48:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 02 Jun 2014 18:46:45 +0100
with message-id <538CB885.3080900 <at> draigBrady.com>
and subject line Re: bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings
has caused the debbugs.gnu.org bug report #17668,
regarding [PATCH] build: be more specific about .git directory before enabling warnings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17668: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17668
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ben Walton <bdwalton <at> gmail.com>
To: bug-coreutils <at> gnu.org
Cc: Ben Walton <bdwalton <at> gmail.com>, P <at> draigbrady.com
Subject: [PATCH] build: be more specific about .git directory before enabling
 warnings
Date: Mon,  2 Jun 2014 09:54:56 +0100

  * configure.ac: When looking for a .git checkout, restrict it to git
    checkouts that contain a coreutils-specific tag.

Signed-off-by: Ben Walton <bdwalton <at> gmail.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a7a8bfc..96af9be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
    # we're running from a git repo, then auto enable the warnings.
    gl_gcc_warnings=no
    gl_GCC_VERSION_IFELSE([4], [6],
-                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
+                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
 )
 
 if test "$gl_gcc_warnings" = yes; then
-- 
1.9.1

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 17668-done <at> debbugs.gnu.org, Ben Walton <bdwalton <at> gmail.com>
Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory
 before enabling warnings
Date: Mon, 02 Jun 2014 18:46:45 +0100

On 06/02/2014 05:31 PM, Eric Blake wrote:
> On 06/02/2014 02:54 AM, Ben Walton wrote:
>>   * configure.ac: When looking for a .git checkout, restrict it to git
>>     checkouts that contain a coreutils-specific tag.
>>
>> Signed-off-by: Ben Walton <bdwalton <at> gmail.com>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index a7a8bfc..96af9be 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
>>     # we're running from a git repo, then auto enable the warnings.
>>     gl_gcc_warnings=no
>>     gl_GCC_VERSION_IFELSE([4], [6],
>> -                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
>> +                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
> 
> NACK.  Git can compress tags to reside in other locations than
> .git/refs/tags (run 'git gc --aggressive' for example).  The idea of
> testing for coreutils.git has merit, but you need to come up with a more
> robust test.

Importing the tarball into git for patch management is a
fine and useful thing to do, so we should support that.

We could probably leverage that .tarball-version is only in the tarball.
I'll merge this in and commit in your name:

  test -d "$srcdir"/.git \
  && ! test -f .tarball-version \
  && gl_gcc_warnings=yes

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.