GNU bug report logs - #17668
[PATCH] build: be more specific about .git directory before enabling warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17668 in the body.
You can then email your comments to 17668 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ben Walton <bdwalton <at> gmail.com>
To: bug-coreutils <at> gnu.org
Cc: Ben Walton <bdwalton <at> gmail.com>, P <at> draigbrady.com
Subject: [PATCH] build: be more specific about .git directory before enabling
 warnings
Date: Mon,  2 Jun 2014 09:54:56 +0100

  * configure.ac: When looking for a .git checkout, restrict it to git
    checkouts that contain a coreutils-specific tag.

Signed-off-by: Ben Walton <bdwalton <at> gmail.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a7a8bfc..96af9be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
    # we're running from a git repo, then auto enable the warnings.
    gl_gcc_warnings=no
    gl_GCC_VERSION_IFELSE([4], [6],
-                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
+                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
 )
 
 if test "$gl_gcc_warnings" = yes; then
-- 
1.9.1

Message #8 received at 17668 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Ben Walton <bdwalton <at> gmail.com>, 17668 <at> debbugs.gnu.org
Cc: P <at> draigbrady.com
Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory
 before enabling warnings
Date: Mon, 02 Jun 2014 10:31:03 -0600

[Message part 1 (text/plain, inline)]

On 06/02/2014 02:54 AM, Ben Walton wrote:
>   * configure.ac: When looking for a .git checkout, restrict it to git
>     checkouts that contain a coreutils-specific tag.
> 
> Signed-off-by: Ben Walton <bdwalton <at> gmail.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index a7a8bfc..96af9be 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
>     # we're running from a git repo, then auto enable the warnings.
>     gl_gcc_warnings=no
>     gl_GCC_VERSION_IFELSE([4], [6],
> -                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
> +                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]

NACK.  Git can compress tags to reside in other locations than
.git/refs/tags (run 'git gc --aggressive' for example).  The idea of
testing for coreutils.git has merit, but you need to come up with a more
robust test.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 17668-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 17668-done <at> debbugs.gnu.org, Ben Walton <bdwalton <at> gmail.com>
Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory
 before enabling warnings
Date: Mon, 02 Jun 2014 18:46:45 +0100

On 06/02/2014 05:31 PM, Eric Blake wrote:
> On 06/02/2014 02:54 AM, Ben Walton wrote:
>>   * configure.ac: When looking for a .git checkout, restrict it to git
>>     checkouts that contain a coreutils-specific tag.
>>
>> Signed-off-by: Ben Walton <bdwalton <at> gmail.com>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index a7a8bfc..96af9be 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
>>     # we're running from a git repo, then auto enable the warnings.
>>     gl_gcc_warnings=no
>>     gl_GCC_VERSION_IFELSE([4], [6],
>> -                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
>> +                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
> 
> NACK.  Git can compress tags to reside in other locations than
> .git/refs/tags (run 'git gc --aggressive' for example).  The idea of
> testing for coreutils.git has merit, but you need to come up with a more
> robust test.

Importing the tarball into git for patch management is a
fine and useful thing to do, so we should support that.

We could probably leverage that .tarball-version is only in the tarball.
I'll merge this in and commit in your name:

  test -d "$srcdir"/.git \
  && ! test -f .tarball-version \
  && gl_gcc_warnings=yes

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.