GNU bug report logs - #17616
patch for svg-clock.el

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: dieter <at> schoen.or.at
Cc: Ulf Jasper <ulf.jasper <at> web.de>, 17616 <at> debbugs.gnu.org
Subject: bug#17616: patch for svg-clock.el
Date: Sat, 31 May 2014 22:04:45 -0400

> I found that because svg-clock calls (image-mode) every second, the message
> "Type C-c C-c to view the image as an image." is displayed at the bottom of
[...]
> --- a/packages/svg-clock/svg-clock.el
> +++ b/packages/svg-clock/svg-clock.el
> @@ -186,7 +186,7 @@ TIME must have the form (SECOND MINUTE HOUR ...), asreturned by `decode-time'."
>        (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size))
>        (svg-clock-replace "%SCALE%"
>                           (format "%f" (/ svg-clock--actual-size 100.0)))
> -      (image-mode)
> -      (image-toggle-display-image))))
> +      (when (derived-mode-p 'image-mode)
> +        (image-toggle-display-image)))))
>  (defun svg-clock-update ()
>    "Update the clock."
> @@ -245,4 +245,5 @@ Optionally PERFORM-UPDATE immediately."
>      (setq svg-clock-timer
>            (run-with-timer 0 1 'svg-clock-update))
>      (svg-clock-mode)
> +    (image-mode)
>      (message "Clock started")))

Your patch was quite mangled, please try to use software that does mess
it up so badly next time.  In any case I installed it into the `elpa'
branch, thank you.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.