GNU bug report logs - #17616
patch for svg-clock.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17616 in the body.
You can then email your comments to 17616 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dieter <at> schoen.or.at
To: bug-gnu-emacs <at> gnu.org
Subject: patch for svg-clock.el
Date: Wed, 28 May 2014 11:24:19 +0000 (GMT)

[Message part 1 (text/plain, inline)]

Hi,
I am using GNU Emacs 24.4.50.2 (x86_64-unknown-linux-gnu, GTK+ Version
3.4.2) of 2014-05-28
and  svg-clock 0.5.
I found that because svg-clock calls (image-mode) every second, the message
"Type C-c C-c to view the image as an image."
is displayed at the bottom of the screen every second.
That overwrites all other messages.
The following patch works for me:
- it switched on image-mode when svg-clock is started
- it only calls image-toggle-display-image when the buffer is in
image-mode.
I have seen that the latest commit fixes an issue with image-mode, but as
far as I can tell,
my patch does not introduce a regression.
diff --git a/packages/svg-clock/svg-clock.el
b/packages/svg-clock/svg-clock.el
index 3897243..ff98e5b 100644
--- a/packages/svg-clock/svg-clock.el
+++ b/packages/svg-clock/svg-clock.el
@@ -186,8 +186,8 @@ TIME must have the form (SECOND MINUTE HOUR ...), as
returned by `decode-time'."
       (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size))
       (svg-clock-replace "%SCALE%"
                          (format "%f" (/ svg-clock--actual-size 100.0)))
-      (image-mode)
-      (image-toggle-display-image))))
+      (when (derived-mode-p 'image-mode)
+        (image-toggle-display-image)))))
 (defun svg-clock-update ()
   "Update the clock."
@@ -245,6 +245,7 @@ Optionally PERFORM-UPDATE immediately."
     (setq svg-clock-timer
           (run-with-timer 0 1 'svg-clock-update))
     (svg-clock-mode)
+    (image-mode)
     (message "Clock started")))
kind regards,
dieter

[Message part 2 (text/html, inline)]

Message #8 received at 17616 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: dieter <at> schoen.or.at
Cc: Ulf Jasper <ulf.jasper <at> web.de>, 17616 <at> debbugs.gnu.org
Subject: Re: bug#17616: patch for svg-clock.el
Date: Sat, 31 May 2014 22:04:45 -0400

> I found that because svg-clock calls (image-mode) every second, the message
> "Type C-c C-c to view the image as an image." is displayed at the bottom of
[...]
> --- a/packages/svg-clock/svg-clock.el
> +++ b/packages/svg-clock/svg-clock.el
> @@ -186,7 +186,7 @@ TIME must have the form (SECOND MINUTE HOUR ...), asreturned by `decode-time'."
>        (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size))
>        (svg-clock-replace "%SCALE%"
>                           (format "%f" (/ svg-clock--actual-size 100.0)))
> -      (image-mode)
> -      (image-toggle-display-image))))
> +      (when (derived-mode-p 'image-mode)
> +        (image-toggle-display-image)))))
>  (defun svg-clock-update ()
>    "Update the clock."
> @@ -245,4 +245,5 @@ Optionally PERFORM-UPDATE immediately."
>      (setq svg-clock-timer
>            (run-with-timer 0 1 'svg-clock-update))
>      (svg-clock-mode)
> +    (image-mode)
>      (message "Clock started")))

Your patch was quite mangled, please try to use software that does mess
it up so badly next time.  In any case I installed it into the `elpa'
branch, thank you.


        Stefan

Message #13 received at 17616 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, dieter <at> schoen.or.at
Cc: 17616 <at> debbugs.gnu.org
Subject: Re: bug#17616: patch for svg-clock.el
Date: Sun, 01 Jun 2014 09:31:44 +0200

> Your patch was quite mangled, please try to use software that does mess
> it up so badly next time.

Please try to not follow such advice.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.