GNU bug report logs - #17472
[PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: behoffski <behoffski <at> grouse.com.au>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings
Date: Mon, 12 May 2014 13:31:24 +0930

[Message part 1 (text/plain, inline)]

A few months ago, "make syntax-check" would complain if any string that
was subject to localisation started with an upper-case character.
Almost all messages in Grep conform to this standard.  However,
"make syntax-check" no longer complains about two cases in the current
master (dfa.c, function lex ()):

    dfaerror (_("Invalid content of \\{\\}"));
    dfaerror (_("Regular expression too big"));

I don't know if this constraint is being relaxed, or if the check has
changed somehow.  (Is syntax-check provided via gnulib?)

Attached is a simple patch that converts the two error strings above to
have a lower-case first character.  This may be useful to help maintain
consistent message formatting.

cheers,

behoffski (Brenton Hoff)
Programmer, Grouse Software

[01-lowercase-lex-dfaerror-messages.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.