GNU bug report logs - #17472
[PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17472 in the body.
You can then email your comments to 17472 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: behoffski <behoffski <at> grouse.com.au>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings
Date: Mon, 12 May 2014 13:31:24 +0930

[Message part 1 (text/plain, inline)]

A few months ago, "make syntax-check" would complain if any string that
was subject to localisation started with an upper-case character.
Almost all messages in Grep conform to this standard.  However,
"make syntax-check" no longer complains about two cases in the current
master (dfa.c, function lex ()):

    dfaerror (_("Invalid content of \\{\\}"));
    dfaerror (_("Regular expression too big"));

I don't know if this constraint is being relaxed, or if the check has
changed somehow.  (Is syntax-check provided via gnulib?)

Attached is a simple patch that converts the two error strings above to
have a lower-case first character.  This may be useful to help maintain
consistent message formatting.

cheers,

behoffski (Brenton Hoff)
Programmer, Grouse Software

[01-lowercase-lex-dfaerror-messages.patch (text/x-patch, attachment)]

Message #8 received at 17472 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: behoffski <behoffski <at> grouse.com.au>
Cc: 17472 <at> debbugs.gnu.org
Subject: Re: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two
 dfaerror strings
Date: Sun, 11 May 2014 23:12:39 -0700

[Message part 1 (text/plain, inline)]

On Sun, May 11, 2014 at 9:01 PM, behoffski <behoffski <at> grouse.com.au> wrote:
> A few months ago, "make syntax-check" would complain if any string that
> was subject to localisation started with an upper-case character.
> Almost all messages in Grep conform to this standard.  However,
> "make syntax-check" no longer complains about two cases in the current
> master (dfa.c, function lex ()):
>
>     dfaerror (_("Invalid content of \\{\\}"));
>     dfaerror (_("Regular expression too big"));
>
> I don't know if this constraint is being relaxed, or if the check has
> changed somehow.  (Is syntax-check provided via gnulib?)
>
> Attached is a simple patch that converts the two error strings above to
> have a lower-case first character.  This may be useful to help maintain
> consistent message formatting.

Thanks for the patch.
That syntax-check rule does indeed come from gnulib, but it
looks only at error-like functions whose names match /[^rp]error/.
That hard-coded pattern would better be customizable.

BTW, those strings were added in 2012.

I've adjusted the commit message to be more consistent, and will
defer pushing your change to master until after the release.
Many translation teams have already updated strings for the
release, so I'd rather not change translatable messages
until after 2.19.

[0001-maint-uncapitalize-first-letter-of-two-dfaerror-mess.patch (application/octet-stream, attachment)]

Message #15 received at 17472-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: behoffski <behoffski <at> grouse.com.au>
Cc: 17472-done <at> debbugs.gnu.org
Subject: Re: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two
 dfaerror strings
Date: Fri, 23 May 2014 22:27:10 -0700

On Sun, May 11, 2014 at 11:12 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sun, May 11, 2014 at 9:01 PM, behoffski <behoffski <at> grouse.com.au> wrote:
>> A few months ago, "make syntax-check" would complain if any string that
>> was subject to localisation started with an upper-case character.
>> Almost all messages in Grep conform to this standard.  However,
>> "make syntax-check" no longer complains about two cases in the current
>> master (dfa.c, function lex ()):
>>
>>     dfaerror (_("Invalid content of \\{\\}"));
>>     dfaerror (_("Regular expression too big"));
>>
>> I don't know if this constraint is being relaxed, or if the check has
>> changed somehow.  (Is syntax-check provided via gnulib?)
>>
>> Attached is a simple patch that converts the two error strings above to
>> have a lower-case first character.  This may be useful to help maintain
>> consistent message formatting.
>
> Thanks for the patch.
> That syntax-check rule does indeed come from gnulib, but it
> looks only at error-like functions whose names match /[^rp]error/.
> That hard-coded pattern would better be customizable.
>
> BTW, those strings were added in 2012.
>
> I've adjusted the commit message to be more consistent, and will
> defer pushing your change to master until after the release.
> Many translation teams have already updated strings for the
> release, so I'd rather not change translatable messages
> until after 2.19.

Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.