GNU bug report logs - #16969
Isearch: lazy-highlight face sometimes has foreground and background the same colour.

Previous Next

Package: emacs;

Reported by: Alan Mackenzie <acm <at> muc.de>

Date: Sat, 8 Mar 2014 18:40:02 UTC

Severity: minor

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 16969 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: Juri Linkov <juri <at> jurta.org>, Alan Mackenzie <acm <at> muc.de>
Cc: 16969 <at> debbugs.gnu.org
Subject: Re: bug#16969: Isearch: lazy-highlight face sometimes has foreground
 and background the same colour.
Date: Sat, 08 Mar 2014 16:45:07 -0800
[Message part 1 (text/plain, inline)]
On 03/08/2014 01:55 PM, Juri Linkov wrote:
>> An effective solution would be to give the `lazy-highlight' face a
>> foreground colour, e.g. black.
> 
> It's useful to keep the foreground color to help seeing the context
> especially when a match is highlighted on a font-look foreground.
> 
> But the problem needs to be fixed anyway.  So maybe we could add the
> face attribute :distant-foreground to the `lazy-highlight' face
> that could be applied only when the background color is near to the
> foreground color like a cyan foreground on a cyan background

And what? Are we going to apply distant-foreground to everything and
hope that the color we choose is legible in whatever theme the user has?
We really need automatic contrast adjustment, not one-off fixes.

[signature.asc (application/pgp-signature, attachment)]

This bug report was last modified 3 years and 165 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.