GNU bug report logs - #16891
24.3; [PATCH] align-regexp now has a separate history for its interactive argument

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 16891 <at> debbugs.gnu.org
Subject: bug#16891: 24.3; [PATCH] align-regexp now has a separate history for its interactive argument
Date: Wed, 24 Feb 2016 14:05:19 +1100

Dima Kogan <dima <at> secretsauce.net> writes:

> Here's a tiny patch to align-regexp. With a prefix argument several
> things are read from the minibuffer using read-input, with one (the
> regex) being much more complicated than the others. It's convenient to
> keep that one in a separate history to make previous entries easily
> selectable.
>

[...]

> +(defvar align-regexp-history nil
> +  "Input history for the full user-entered regex in `align-regexp'")
> +
>  ;; Sample extension rule set, for vhdl-mode.  This should properly be
>  ;; in vhdl-mode.el itself.
>  
> @@ -946,7 +949,7 @@ construct a rule to pass to `align-region', which does the real work."
>      (list (region-beginning) (region-end))
>      (if current-prefix-arg
>  	(list (read-string "Complex align using regexp: "
> -			   "\\(\\s-*\\)")
> +                          "\\(\\s-*\\)" 'align-regexp-history)

I think that makes sense.  Could you resubmit this patch with an
etc/NEWS entry, and a possible documentation change?  I'm not sure
whether we usually mention separate histories for commands or not,
though...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.