GNU bug report logs - #16891
24.3; [PATCH] align-regexp now has a separate history for its interactive argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16891 in the body.
You can then email your comments to 16891 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3;
 [PATCH] align-regexp now has a separate history for its interactive
 argument
Date: Thu, 27 Feb 2014 02:54:20 -0800

[Message part 1 (text/plain, inline)]

Here's a tiny patch to align-regexp. With a prefix argument several
things are read from the minibuffer using read-input, with one (the
regex) being much more complicated than the others. It's convenient to
keep that one in a separate history to make previous entries easily
selectable.

[0001-align-regexp-now-has-a-separate-history-for-its-inte.patch (text/x-diff, attachment)]

Message #8 received at 16891 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 16891 <at> debbugs.gnu.org
Subject: Re: bug#16891: 24.3;
 [PATCH] align-regexp now has a separate history for its interactive
 argument
Date: Wed, 24 Feb 2016 14:05:19 +1100

Dima Kogan <dima <at> secretsauce.net> writes:

> Here's a tiny patch to align-regexp. With a prefix argument several
> things are read from the minibuffer using read-input, with one (the
> regex) being much more complicated than the others. It's convenient to
> keep that one in a separate history to make previous entries easily
> selectable.
>

[...]

> +(defvar align-regexp-history nil
> +  "Input history for the full user-entered regex in `align-regexp'")
> +
>  ;; Sample extension rule set, for vhdl-mode.  This should properly be
>  ;; in vhdl-mode.el itself.
>  
> @@ -946,7 +949,7 @@ construct a rule to pass to `align-region', which does the real work."
>      (list (region-beginning) (region-end))
>      (if current-prefix-arg
>  	(list (read-string "Complex align using regexp: "
> -			   "\\(\\s-*\\)")
> +                          "\\(\\s-*\\)" 'align-regexp-history)

I think that makes sense.  Could you resubmit this patch with an
etc/NEWS entry, and a possible documentation change?  I'm not sure
whether we usually mention separate histories for commands or not,
though...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 16891 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16891 <at> debbugs.gnu.org
Subject: Re: bug#16891: 24.3;
 [PATCH] align-regexp now has a separate history for its interactive
 argument
Date: Sat, 27 Feb 2016 18:49:55 -0800

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Could you resubmit this patch with an etc/NEWS entry, and a possible
> documentation change? I'm not sure whether we usually mention separate
> histories for commands or not, though...

Patch attached. I'm assuming this is going to master (NEWS entry in
25.2) and that no documentation change is necessary. This seems too
small to document

[0001-align-regexp-now-has-a-separate-history-for-its-inte.patch (text/x-diff, inline)]

From c973972cbac84e0c9e228376a547df3eddb001f3 Mon Sep 17 00:00:00 2001
From: Dima Kogan <dima <at> secretsauce.net>
Date: Thu, 27 Feb 2014 02:45:43 -0800
Subject: [PATCH] `align-regexp' now has a separate history for its interactive
 argument

lisp/align.el (align-regexp-history): New variable (bug#16891)
---
 etc/NEWS      | 5 +++++
 lisp/align.el | 5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index ec68cce..aec34c3 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -31,6 +31,11 @@ otherwise leave it unmarked.
 
 * Changes in Emacs 25.2
 
+---
+** `align-regexp' has a separate history for its interactive argument
+`align-regexp' no longer shares its history with all other
+history-less functions that use `read-string'
+
 +++
 ** The networking code has been reworked so that it's more
 asynchronous than it was (when specifying :nowait t in
diff --git a/lisp/align.el b/lisp/align.el
index 7e439f3..c3389dc 100644
--- a/lisp/align.el
+++ b/lisp/align.el
@@ -802,6 +802,9 @@ align-mode-exclude-rules-list
 (defvar align-highlight-overlays nil
   "The current overlays highlighting the text matched by a rule.")
 
+(defvar align-regexp-history nil
+  "Input history for the full user-entered regex in `align-regexp'")
+
 ;; Sample extension rule set, for vhdl-mode.  This should properly be
 ;; in vhdl-mode.el itself.
 
@@ -946,7 +949,7 @@ align-regexp
     (list (region-beginning) (region-end))
     (if current-prefix-arg
 	(list (read-string "Complex align using regexp: "
-			   "\\(\\s-*\\)")
+                          "\\(\\s-*\\)" 'align-regexp-history)
 	      (string-to-number
 	       (read-string
 		"Parenthesis group to modify (justify if negative): " "1"))
-- 
2.1.4

Message #14 received at 16891 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 16891 <at> debbugs.gnu.org
Subject: Re: bug#16891: 24.3;
 [PATCH] align-regexp now has a separate history for its interactive
 argument
Date: Sun, 28 Feb 2016 15:15:27 +1030

Dima Kogan <dima <at> secretsauce.net> writes:

> Patch attached. I'm assuming this is going to master (NEWS entry in
> 25.2) and that no documentation change is necessary. This seems too
> small to document

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.