GNU bug report logs - #16229
[PATCH] Sync partitions > 16

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16229: closed ([PATCH] Sync partitions > 16)
Date: Thu, 06 Mar 2014 01:47:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 05 Mar 2014 20:46:29 -0500
with message-id <5317D375.3080604 <at> ubuntu.com>
and subject line Re: bug#16229: [PATCH] Sync partitions > 16
has caused the debbugs.gnu.org bug report #16229,
regarding [PATCH] Sync partitions > 16
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16229: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16229
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Phillip Susi <psusi <at> ubuntu.com>
To: bug-parted <at> gnu.org
Subject: [PATCH] Sync partitions > 16
Date: Mon, 23 Dec 2013 15:28:22 -0500

The linux partition sync code was hard coded to only 16 partitions.
---
 NEWS                   | 3 +++
 libparted/arch/linux.c | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 816fb57..2d0c6b9 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,9 @@ GNU parted NEWS                                    -*- outline -*-
   boot partition type.
 
 ** Bug Fixes
+
+  Fix linux partition sync code to include partitions > 16
+
   Fix several bugs with loop labels ( whole disk filesystems )
 
   Fix gpt to correctly handle non ASCII charcters in partition names
diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 8a09763..6d3234e 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -1567,6 +1567,7 @@ _flush_cache (PedDevice* dev)
 {
         LinuxSpecific*  arch_specific = LINUX_SPECIFIC (dev);
         int             i;
+	int             lpn = _device_get_partition_range(dev);
 
         if (dev->read_only)
                 return;
@@ -1574,7 +1575,7 @@ _flush_cache (PedDevice* dev)
 
         ioctl (arch_specific->fd, BLKFLSBUF);
 
-        for (i = 1; i < 16; i++) {
+        for (i = 1; i < lpn; i++) {
                 char*           name;
                 int             fd;
 
-- 
1.8.3.2

[Message part 3 (message/rfc822, inline)]

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, 16229-done <at> debbugs.gnu.org
Subject: Re: bug#16229: [PATCH] Sync partitions > 16
Date: Wed, 05 Mar 2014 20:46:29 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/03/2014 01:02 PM, Brian C. Lane wrote:
> Ack. A quick grep shows that this may be the last 16 limit left :)

Thanks, pushed.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTF9N1AAoJEI5FoCIzSKrwhv0IAI7faXSDy77VvhQjLSae1yEU
xxJFUgtUY3YO1h1I+6t/g984at4RSsQQsjJmWITrBWjEoX0frqUtsofW363Q5CYV
nxeWU2XA1IacY6q8UWhX/ae3BqXUzOnXn11KgKyZa9+Q4YOdPveuQRERoA5sq+Lu
LBAhyOJMUuwOB4mZuYT7Jxsv7nnQtSO+nRPGB8yW96g52AZ3Qi4oKmeZ0plqcaex
vv1v1Mgi9mx5IAMlWWpWkf1Cqpx6rZiLka8NxKEDYlO7B5j5VcrPafk8PwM2Q+y3
SxJ9SydsiqwS8vB8hWwXWiL1xZwhbJomT8u51P3h0anN8QmGA91MSn9ep5pibCI=
=HHDD
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.