GNU bug report logs - #16229
[PATCH] Sync partitions > 16

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16229 in the body.
You can then email your comments to 16229 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: bug-parted <at> gnu.org
Subject: [PATCH] Sync partitions > 16
Date: Mon, 23 Dec 2013 15:28:22 -0500

The linux partition sync code was hard coded to only 16 partitions.
---
 NEWS                   | 3 +++
 libparted/arch/linux.c | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 816fb57..2d0c6b9 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,9 @@ GNU parted NEWS                                    -*- outline -*-
   boot partition type.
 
 ** Bug Fixes
+
+  Fix linux partition sync code to include partitions > 16
+
   Fix several bugs with loop labels ( whole disk filesystems )
 
   Fix gpt to correctly handle non ASCII charcters in partition names
diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 8a09763..6d3234e 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -1567,6 +1567,7 @@ _flush_cache (PedDevice* dev)
 {
         LinuxSpecific*  arch_specific = LINUX_SPECIFIC (dev);
         int             i;
+	int             lpn = _device_get_partition_range(dev);
 
         if (dev->read_only)
                 return;
@@ -1574,7 +1575,7 @@ _flush_cache (PedDevice* dev)
 
         ioctl (arch_specific->fd, BLKFLSBUF);
 
-        for (i = 1; i < 16; i++) {
+        for (i = 1; i < lpn; i++) {
                 char*           name;
                 int             fd;
 
-- 
1.8.3.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: bug-parted <at> gnu.org
Subject: Re: bug#16229: [PATCH] Sync partitions > 16
Date: Mon, 3 Mar 2014 10:02:05 -0800

On Mon, Dec 23, 2013 at 03:28:22PM -0500, Phillip Susi wrote:
> The linux partition sync code was hard coded to only 16 partitions.
> ---
>  NEWS                   | 3 +++
>  libparted/arch/linux.c | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS b/NEWS
> index 816fb57..2d0c6b9 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -12,6 +12,9 @@ GNU parted NEWS                                    -*- outline -*-
>    boot partition type.
>  
>  ** Bug Fixes
> +
> +  Fix linux partition sync code to include partitions > 16
> +
>    Fix several bugs with loop labels ( whole disk filesystems )
>  
>    Fix gpt to correctly handle non ASCII charcters in partition names
> diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
> index 8a09763..6d3234e 100644
> --- a/libparted/arch/linux.c
> +++ b/libparted/arch/linux.c
> @@ -1567,6 +1567,7 @@ _flush_cache (PedDevice* dev)
>  {
>          LinuxSpecific*  arch_specific = LINUX_SPECIFIC (dev);
>          int             i;
> +	int             lpn = _device_get_partition_range(dev);
>  
>          if (dev->read_only)
>                  return;
> @@ -1574,7 +1575,7 @@ _flush_cache (PedDevice* dev)
>  
>          ioctl (arch_specific->fd, BLKFLSBUF);
>  
> -        for (i = 1; i < 16; i++) {
> +        for (i = 1; i < lpn; i++) {
>                  char*           name;
>                  int             fd;
>  
> -- 
> 1.8.3.2

Ack. A quick grep shows that this may be the last 16 limit left :)


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Message #13 received at 16229-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, 16229-done <at> debbugs.gnu.org
Subject: Re: bug#16229: [PATCH] Sync partitions > 16
Date: Wed, 05 Mar 2014 20:46:29 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 03/03/2014 01:02 PM, Brian C. Lane wrote:
> Ack. A quick grep shows that this may be the last 16 limit left :)

Thanks, pushed.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTF9N1AAoJEI5FoCIzSKrwhv0IAI7faXSDy77VvhQjLSae1yEU
xxJFUgtUY3YO1h1I+6t/g984at4RSsQQsjJmWITrBWjEoX0frqUtsofW363Q5CYV
nxeWU2XA1IacY6q8UWhX/ae3BqXUzOnXn11KgKyZa9+Q4YOdPveuQRERoA5sq+Lu
LBAhyOJMUuwOB4mZuYT7Jxsv7nnQtSO+nRPGB8yW96g52AZ3Qi4oKmeZ0plqcaex
vv1v1Mgi9mx5IAMlWWpWkf1Cqpx6rZiLka8NxKEDYlO7B5j5VcrPafk8PwM2Q+y3
SxJ9SydsiqwS8vB8hWwXWiL1xZwhbJomT8u51P3h0anN8QmGA91MSn9ep5pibCI=
=HHDD
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.