GNU bug report logs - #16136
24.3.50; `minibuffer-prompt-properties' for `face'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Fri, 13 Dec 2013 23:33:01 UTC

Severity: wishlist

Tags: fixed

Merged with 12377

Found in versions 24.2.50, 24.3.50

Fixed in version 26.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16136 in the body.
You can then email your comments to 16136 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16136; Package emacs. (Fri, 13 Dec 2013 23:33:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 13 Dec 2013 23:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; `minibuffer-prompt-properties' for `face'
Date: Fri, 13 Dec 2013 15:31:29 -0800 (PST)
It is good to have variable `minibuffer-prompt-properties'.  And it is
good that by default its value includes `face' with a value of
`minibuffer-prompt'.  This allows the prompt, by default, to stand out
against the user input.

However, the design should be more supple.  It should use the `face'
property specified in `minibuffer-prompt-properties', if any, to apply
that face only to parts of the PROMPT string that do not already have a
`face' text property.  Any parts of PROMPT that are already propertized
with property `face' should be left alone, and not have their face
overridden by face `minibuffer-prompt'.

This would let users supply a PROMPT string that already has certain
parts highlighted with faces, so that they, in turn, stand out against
the rest of the prompt.

In order to get that effect now, users have to propertize the entire
PROMPT string, highlighting not only the particular part(s) they want to
emphasize, but also providing face `minibuffer-prompt' for the other
parts.  If they do not do the latter then the prompt as a whole does
not stand out against the user input: it has no special face except for
the particular part(s) highlighted.

This enhancement apparently needs to be done in the C code
(`read_minibuf'), which means also that users cannot implement this
improvement themselves, in Lisp.



In GNU Emacs 24.3.50.2 (i686-pc-mingw32)
 of 2013-11-28 on LEG570
Bzr revision: 115271 rgm <at> gnu.org-20131128203155-qjc1xsp19z2k64b2
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16136; Package emacs. (Fri, 13 Dec 2013 23:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 16136 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 16136 <at> debbugs.gnu.org
Subject: RE: bug#16136: 24.3.50; `minibuffer-prompt-properties' for `face'
Date: Fri, 13 Dec 2013 15:47:39 -0800 (PST)
Perhaps I should add, if it wasn't obvious, that anyone wanting
the current behavior can just do one of the following:

* Not propertize PROMPT using a `face' property, to get the
  default behavior.

* Propertize PROMPT using `face' zones, but bind
  `minibuffer-prompt-properties' to a value without `face', to
  get the same behavior as now when it has no `face' behavior.

IOW, this enhancement does not lose any current features.  It
just gives users more flexibility, letting them have prompts
that emphasize certain parts.




Severity set to 'wishlist' from 'minor' Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 08 Feb 2014 02:54:01 GMT) Full text and rfc822 format available.

Forcibly Merged 12377 16136. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 29 Apr 2016 14:49:02 GMT) Full text and rfc822 format available.

Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 01 May 2016 14:55:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 25.2, send any further explanations to 12377 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 01 May 2016 14:55:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 30 May 2016 11:24:04 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Drew Adams <drew.adams <at> oracle.com> to control <at> debbugs.gnu.org. (Fri, 24 Jun 2016 16:32:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 23 Jul 2016 11:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug Marked as fixed in versions 26.1. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug No longer marked as fixed in versions 25.2. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Jan 2017 12:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 229 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.