GNU bug report logs - #15967
24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Subject: bug#15967: closed (Re: bug#15966: bug#15967: 24.3.50; [PATCH]
 eww: use eww-browse-url, when url in bookmark list is opened, bug#15966:
 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965:
 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910:
 24.3.50; [PATCH] eww: Current URL is not entered automatically, after
 ewwstarts.s.)
Date: Tue, 26 Nov 2013 20:10:11 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15967 <at> debbugs.gnu.org.

-- 
15967: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15967
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Cc: 15965-done <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 15966-done <at> debbugs.gnu.org, 15910-done <at> debbugs.gnu.org,
 15967-done <at> debbugs.gnu.org
Subject: Re: bug#15966: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Tue, 26 Nov 2013 15:10:31 -0500

On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted

[Message part 3 (message/rfc822, inline)]

From: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened
Date: Mon, 25 Nov 2013 00:15:52 +0900

Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
doesn't save current URL in eww-history.

Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

        * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6f09d86..738136b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1065,7 +1065,7 @@ The browser to used is specified by the `shr-external-browser' variable."
     ;; just let it remain.
     (ignore-errors
       (delete-window))
-    (eww (plist-get bookmark :url))))
+    (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
   "Go to the next bookmark in the list."
--
1.8.3.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.