GNU bug report logs - #15967
24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15967 in the body.
You can then email your comments to 15967 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened
Date: Mon, 25 Nov 2013 00:15:52 +0900

Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
doesn't save current URL in eww-history.

Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

        * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6f09d86..738136b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1065,7 +1065,7 @@ The browser to used is specified by the `shr-external-browser' variable."
     ;; just let it remain.
     (ignore-errors
       (delete-window))
-    (eww (plist-get bookmark :url))))
+    (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
   "Go to the next bookmark in the list."
--
1.8.3.1

Message #8 received at 15967 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Cc: 15910 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 15966 <at> debbugs.gnu.org, 15967 <at> debbugs.gnu.org, 15965 <at> debbugs.gnu.org
Subject: Re: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Mon, 25 Nov 2013 09:54:32 -0500

Thank you for the patches.  All of them are OK to go in IMO (and tiny
changes).  Could you consolidate them in a single patch with a ChangeLog
please?  It can wait for your eww history stack changes or can be
submitted sooner.

Thanks
Ted

On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
KN> doesn't save current URL in eww-history.

KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

KN>         * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.

On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> eww should ask "yes or no" when add current page to bookmarks, since
KN> only "b" key to add bookmarks is easy to mistake.
KN> (My bookmarklist has amazingly increased.)

KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

KN>         * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks

On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> eww should ask "yes or no" before quitting, since only "q" key to quit is
KN> easy to mistake.

KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

KN>         * net/eww.el (eww-quit): ask confirmation before quitting eww

On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> Thank you for your review, Ted, Masatake.

KN> OK, I try to revise the patch to add eww own history stack.
KN> And I put ChangeLog entry to my report next time.

Message #11 received at 15967 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>, 15966 <at> debbugs.gnu.org,
 15967 <at> debbugs.gnu.org, 15965 <at> debbugs.gnu.org, 15910 <at> debbugs.gnu.org,
 Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Subject: Re: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Tue, 26 Nov 2013 20:51:49 +0900

Thanks, Ted.
I consolidated the patches, please include the patch if appreciated.


Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com> 

        * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.
        (eww-add-bookmark): ask confirmation when add to bookmarks
        (eww-quit): ask confirmation before quitting eww

---
 lisp/net/eww.el | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 86e0977..4b8b067 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'."
 (defun eww-quit ()
   "Exit the Emacs Web Wowser."
   (interactive)
-  (setq eww-history nil)
-  (kill-buffer (current-buffer)))
+  (if (y-or-n-p "quit eww? ")
+      (progn
+	(setq eww-history nil)
+	(kill-buffer (current-buffer)))))
 
 (defun eww-back-url ()
   "Go to the previously displayed page."
@@ -964,14 +966,16 @@ The browser to used is specified by the `shr-external-browser' variable."
     (when (equal eww-current-url
 		 (plist-get bookmark :url))
       (error "Already bookmarked")))
-  (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title)))
-    (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title))
-    (push (list :url eww-current-url
-		:title title
-		:time (current-time-string))
-	  eww-bookmarks))
-  (eww-write-bookmarks)
-  (message "Bookmarked %s (%s)" eww-current-url eww-current-title))
+  (if (y-or-n-p "add bookmark this page? ")
+      (progn
+	(let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title)))
+	  (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title))
+	  (push (list :url eww-current-url
+		      :title title
+		      :time (current-time-string))
+		eww-bookmarks))
+	(eww-write-bookmarks)
+	(message "Bookmarked %s (%s)" eww-current-url eww-current-title))))
 
 (defun eww-write-bookmarks ()
   (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory)
@@ -1063,7 +1067,7 @@ The browser to used is specified by the `shr-external-browser' variable."
     ;; just let it remain.
     (ignore-errors
       (delete-window))
-    (eww (plist-get bookmark :url))))
+    (eww-browse-url (plist-get bookmark :url))))
 
 (defun eww-next-bookmark ()
   "Go to the next bookmark in the list."
-- 
1.8.3.1

Thanks,

Kenjiro Nakayama

        

tzz <at> lifelogs.com writes:

> Thank you for the patches.  All of them are OK to go in IMO (and tiny
> changes).  Could you consolidate them in a single patch with a ChangeLog
> please?  It can wait for your eww history stack changes or can be
> submitted sooner.
>
> Thanks
> Ted
>
> On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 
>
> KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
> KN> doesn't save current URL in eww-history.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
>
> KN>         * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.
>
> On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 
>
> KN> eww should ask "yes or no" when add current page to bookmarks, since
> KN> only "b" key to add bookmarks is easy to mistake.
> KN> (My bookmarklist has amazingly increased.)
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
>
> KN>         * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks
>
> On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 
>
> KN> eww should ask "yes or no" before quitting, since only "q" key to quit is
> KN> easy to mistake.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
>
> KN>         * net/eww.el (eww-quit): ask confirmation before quitting eww
>
> On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 
>
> KN> Thank you for your review, Ted, Masatake.
>
> KN> OK, I try to revise the patch to add eww own history stack.
> KN> And I put ChangeLog entry to my report next time.

Message #16 received at 15967-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Cc: 15965-done <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 15966-done <at> debbugs.gnu.org, 15910-done <at> debbugs.gnu.org,
 15967-done <at> debbugs.gnu.org
Subject: Re: bug#15966: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Tue, 26 Nov 2013 15:10:31 -0500

On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.