GNU bug report logs - #15966
24.3.50; [PATCH] eww: ask confirmation when add bookmarks

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Subject: bug#15966: closed (Re: bug#15966: bug#15967: 24.3.50; [PATCH]
 eww: use eww-browse-url, when url in bookmark list is opened, bug#15966:
 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965:
 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910:
 24.3.50; [PATCH] eww: Current URL is not entered automatically, after
 ewwstarts.s.)
Date: Tue, 26 Nov 2013 20:10:08 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15966 <at> debbugs.gnu.org.

-- 
15966: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15966
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Cc: 15965-done <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 15966-done <at> debbugs.gnu.org, 15910-done <at> debbugs.gnu.org,
 15967-done <at> debbugs.gnu.org
Subject: Re: bug#15966: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Tue, 26 Nov 2013 15:10:31 -0500

On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted

[Message part 3 (message/rfc822, inline)]

From: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks
Date: Sun, 24 Nov 2013 23:41:44 +0900

eww should ask "yes or no" when add current page to bookmarks, since
only "b" key to add bookmarks is easy to mistake.
(My bookmarklist has amazingly increased.)

Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

        * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks

---
 lisp/net/eww.el | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 86e0977..6f09d86 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -964,14 +964,16 @@ The browser to used is specified by the `shr-external-browser' variable."
     (when (equal eww-current-url
                 (plist-get bookmark :url))
       (error "Already bookmarked")))
-  (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title)))
-    (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title))
-    (push (list :url eww-current-url
-               :title title
-               :time (current-time-string))
-         eww-bookmarks))
-  (eww-write-bookmarks)
-  (message "Bookmarked %s (%s)" eww-current-url eww-current-title))
+  (if (y-or-n-p "add bookmark this page? ")
+      (progn
+       (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title)))
+         (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title))
+         (push (list :url eww-current-url
+                     :title title
+                     :time (current-time-string))
+               eww-bookmarks))
+       (eww-write-bookmarks)
+       (message "Bookmarked %s (%s)" eww-current-url eww-current-title))))

 (defun eww-write-bookmarks ()
   (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory)
-- 
1.8.3.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.