GNU bug report logs - #15934
[Feature request] Highlight full lines

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15934: closed ([Feature request] Highlight full lines)
Date: Fri, 23 Aug 2019 12:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 23 Aug 2019 14:00:53 +0200
with message-id <87r25cozuy.fsf <at> web.de>
and subject line Re: bug#15934: [Feature request] Highlight full lines
has caused the debbugs.gnu.org bug report #15934,
regarding [Feature request] Highlight full lines
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15934: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15934
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Sebastien Vauban" <sva-news <at> mygooglest.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Feature request] Highlight full lines
Date: Wed, 20 Nov 2013 20:24:01 +0100

Hello,

I think it'd be nicer to highlight full lines (vs up to the last character)
when using C-x w l (highlight-lines-matching-regexp).

Best regards,
  Seb

-- 
Sebastien Vauban

[Message part 3 (message/rfc822, inline)]

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 15934-done <at> debbugs.gnu.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Fri, 23 Aug 2019 14:00:53 +0200

[Message part 4 (text/plain, inline)]

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> I'll install the suggested patch in a couple of days if no one objects.

Done, with a minor correction:

[0001-Hi-lock-lines-up-to-right-margin-Bug-15934.patch (text/x-diff, inline)]

From d534687c43a1517e291b8de31e3ce23c2e6e4603 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen <at> web.de>
Date: Wed, 21 Aug 2019 15:51:13 +0200
Subject: [PATCH] Hi-lock lines up to right margin (Bug#15934)

* lisp/hi-lock.el (hi-lock-line-face-buffer): Change used regexp so
that a line terminating newline character is included in the match.
---
 lisp/hi-lock.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index 65465d3b4c..b6b0e2a736 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -447,7 +447,7 @@ hi-lock-line-face-buffer
   (hi-lock-set-pattern
    ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
    ;; or a trailing $ in REGEXP will be interpreted correctly.
-   (concat "^.*\\(?:" regexp "\\).*$") face))
+   (concat "^.*\\(?:" regexp "\\).*\\(?:$\\)\n?") face))


 ;;;###autoload
--
2.23.0.rc1

[Message part 6 (text/plain, inline)]

The installed patch uses a shy group to wrap the $ operator.  Doesn't
change the behavior but should be more correct.

Thanks,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.