GNU bug report logs - #15934
[Feature request] Highlight full lines

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15934 in the body.
You can then email your comments to 15934 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Sebastien Vauban" <sva-news <at> mygooglest.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Feature request] Highlight full lines
Date: Wed, 20 Nov 2013 20:24:01 +0100

Hello,

I think it'd be nicer to highlight full lines (vs up to the last character)
when using C-x w l (highlight-lines-matching-regexp).

Best regards,
  Seb

-- 
Sebastien Vauban

Message #8 received at 15934 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Sebastien Vauban <public-sva-news-D0wtAvR13HarG/iDocfnWg <at> plane.gmane.org>
Cc: public-15934-ubl+/3LiMTaZdePnXv/OxA <at> plane.gmane.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Wed, 11 Dec 2013 02:41:14 +0100

[Message part 1 (text/plain, inline)]

Hi Sebastien,

> I think it'd be nicer to highlight full lines (vs up to the last character)
> when using C-x w l (highlight-lines-matching-regexp).

I too think that this would be more appropriate.  Something like
the following should do the job:

[hi-lock.patch (text/x-diff, inline)]

*** /home/micha/software/emacs/lisp/hi-lock.el	2013-10-26 18:26:42.117620602 +0200
--- /home/micha/today/hi-lock.el	2013-12-11 02:31:03.251432385 +0100
***************
*** 448,454 ****
    (hi-lock-set-pattern
     ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
     ;; or a trailing $ in REGEXP will be interpreted correctly.
!    (concat "^.*\\(?:" regexp "\\).*$") face))
  
  
  ;;;###autoload
--- 448,454 ----
    (hi-lock-set-pattern
     ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
     ;; or a trailing $ in REGEXP will be interpreted correctly.
!    (concat "^.*\\(?:" regexp "\\).*\\($\\)\n?") face))
  
  
  ;;;###autoload

[Message part 3 (text/plain, inline)]

Can we use this?


Regards,

Michael.

Message #11 received at 15934 <at> debbugs.gnu.org (full text, mbox):

From: "Sebastien Vauban" <sva-news <at> mygooglest.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: public-15934-ubl+/3LiMTaZdePnXv/OxA <at> plane.gmane.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Wed, 11 Dec 2013 13:40:55 +0100

Hello Michael,

Michael Heerdegen wrote:
>> I think it'd be nicer to highlight full lines (vs up to the last character)
>> when using C-x w l (highlight-lines-matching-regexp).
>
> I too think that this would be more appropriate.  Something like
> the following should do the job:
>
>
> *** /home/micha/software/emacs/lisp/hi-lock.el	2013-10-26 18:26:42.117620602 +0200
> --- /home/micha/today/hi-lock.el	2013-12-11 02:31:03.251432385 +0100
> ***************
> *** 448,454 ****
>     (hi-lock-set-pattern
>      ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
>      ;; or a trailing $ in REGEXP will be interpreted correctly.
> !    (concat "^.*\\(?:" regexp "\\).*$") face))
>   
>   
>   ;;;###autoload
> --- 448,454 ----
>     (hi-lock-set-pattern
>      ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
>      ;; or a trailing $ in REGEXP will be interpreted correctly.
> !    (concat "^.*\\(?:" regexp "\\).*\\($\\)\n?") face))
>   
>   
>   ;;;###autoload
>
>
> Can we use this?

I've tested it. It does what I wish it should do!

Thanks...

Best regards,
  Seb

-- 
Sebastien Vauban

Message #14 received at 15934 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Sebastien Vauban <public-sva-news-D0wtAvR13HarG/iDocfnWg <at> plane.gmane.org>,
 15934 <at> debbugs.gnu.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Sun, 18 Aug 2019 19:52:43 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> Hi Sebastien,
>
>> I think it'd be nicer to highlight full lines (vs up to the last character)
>> when using C-x w l (highlight-lines-matching-regexp).
>
> I too think that this would be more appropriate.  Something like
> the following should do the job:
>
> *** /home/micha/software/emacs/lisp/hi-lock.el    2013-10-26 18:26:42.117620602 +0200
> --- /home/micha/today/hi-lock.el    2013-12-11 02:31:03.251432385 +0100
> ***************
> *** 448,454 ****
>     (hi-lock-set-pattern
>      ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
>      ;; or a trailing $ in REGEXP will be interpreted correctly.
> !    (concat "^.*\\(?:" regexp "\\).*$") face))
>
>
>   ;;;###autoload
> --- 448,454 ----
>     (hi-lock-set-pattern
>      ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
>      ;; or a trailing $ in REGEXP will be interpreted correctly.
> !    (concat "^.*\\(?:" regexp "\\).*\\($\\)\n?") face))
>
>
>   ;;;###autoload
>
>
> Can we use this?
>
>
> Regards,
>
> Michael.

The suggested change works here, and I think the new behaviour makes
more sense.  The user would want this to stand out, and it can be hard
to spot short lines.

Are there any objections to making this change?  If there are none,
could you Michael please consider committing this to master?

Thanks,
Stefan Kangas

Message #17 received at 15934 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 15934 <at> debbugs.gnu.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Mon, 19 Aug 2019 15:58:30 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Are there any objections to making this change?  If there are none,
> could you Michael please consider committing this to master?

I'll install the suggested patch in a couple of days if no one objects.

Thanks,

Michael.

Message #22 received at 15934-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 15934-done <at> debbugs.gnu.org
Subject: Re: bug#15934: [Feature request] Highlight full lines
Date: Fri, 23 Aug 2019 14:00:53 +0200

[Message part 1 (text/plain, inline)]

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> I'll install the suggested patch in a couple of days if no one objects.

Done, with a minor correction:

[0001-Hi-lock-lines-up-to-right-margin-Bug-15934.patch (text/x-diff, inline)]

From d534687c43a1517e291b8de31e3ce23c2e6e4603 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen <at> web.de>
Date: Wed, 21 Aug 2019 15:51:13 +0200
Subject: [PATCH] Hi-lock lines up to right margin (Bug#15934)

* lisp/hi-lock.el (hi-lock-line-face-buffer): Change used regexp so
that a line terminating newline character is included in the match.
---
 lisp/hi-lock.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index 65465d3b4c..b6b0e2a736 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -447,7 +447,7 @@ hi-lock-line-face-buffer
   (hi-lock-set-pattern
    ;; The \\(?:...\\) grouping construct ensures that a leading ^, +, * or ?
    ;; or a trailing $ in REGEXP will be interpreted correctly.
-   (concat "^.*\\(?:" regexp "\\).*$") face))
+   (concat "^.*\\(?:" regexp "\\).*\\(?:$\\)\n?") face))


 ;;;###autoload
--
2.23.0.rc1

[Message part 3 (text/plain, inline)]

The installed patch uses a shy group to wrap the $ operator.  Doesn't
change the behavior but should be more correct.

Thanks,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.