GNU bug report logs - #15884
24.3; image-dired is mixing up buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15884 in the body.
You can then email your comments to 15884 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: eschulte <at> cs.unm.edu
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; image-dired is mixing up buffers
Date: Wed, 13 Nov 2013 09:36:29 -0700

When in an `image-dired-thumbnail-mode' buffer the movement functions
(`image-dired-forward-image' and `image-dired-backward-image') get
confused if the corresponding dired buffer is not visible and throws the
point to the end of the thumbnail buffer making navigation impossible.
Changing the definition of `image-dired-track-original-file' from the
original,

    (defun image-dired-track-original-file ()
      "Track the original file in the associated dired buffer.
    See documentation for `image-dired-toggle-movement-tracking'.
    Interactive use only useful if `image-dired-track-movement' is nil."
      (interactive)
      (let ((old-buf (current-buffer))
            (dired-buf (image-dired-associated-dired-buffer))
            (file-name (image-dired-original-file-name)))
        (when (and (buffer-live-p dired-buf) file-name)
          (set-buffer dired-buf)
          (if (not (dired-goto-file file-name))
              (message "Could not track file")
            (set-window-point
             (image-dired-get-buffer-window dired-buf) (point)))
          (set-buffer old-buf))))

to the following

    (defun image-dired-track-original-file ()
      "Track the original file in the associated dired buffer.
    See documentation for `image-dired-toggle-movement-tracking'.
    Interactive use only useful if `image-dired-track-movement' is nil."
      (interactive)
      (let ((old-buf (current-buffer))
            (dired-buf (image-dired-associated-dired-buffer))
            (file-name (image-dired-original-file-name)))
        (when (and (buffer-live-p dired-buf) file-name)
          (set-buffer dired-buf)
          (if (not (dired-goto-file file-name))
              (message "Could not track file")
            (let ((window (image-dired-get-buffer-window dired-buf)))
              (if window (set-window-point window (point))
                (message "Could not find associated dired buffer."))))
          (set-buffer old-buf))))

fixes this bug.

Best, Eric

Message #8 received at 15884 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: eschulte <at> cs.unm.edu
Cc: 15884 <at> debbugs.gnu.org
Subject: Re: bug#15884: 24.3; image-dired is mixing up buffers
Date: Wed, 13 Nov 2013 11:54:49 -0500

I believe this is already fixed in Emacs trunk.
http://debbugs.gnu.org/14909

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.