GNU bug report logs - #15819
colorls.csh errors out if "noclobber" is set (coreutils 8.21.11, Fedora19)

Previous Next

Full log

View this message in rfc822 format

From: Ondrej Vasik <ovasik <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: Ty! Boyack <ty.boyack <at> colostate.edu>, 15819-done <at> debbugs.gnu.org
Subject: bug#15819: colorls.csh errors out if "noclobber" is set (coreutils 8.21.11, Fedora19)
Date: Wed, 06 Nov 2013 14:30:29 +0100

On Wed, 2013-11-06 at 14:09 +0100, Bernhard Voelker wrote:
> tag 15819 notabug
> thanks
> 
> [added Ondrej]
> 
> > On November 6, 2013 at 8:00 AM Ty! Boyack <ty.boyack <at> colostate.edu> wrote:
> > Behavior:
> >
> > The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> > installation, but if a local admin adds a default shell setting of
> > "noclobber" in a profile setting that runs before this script (as we do)
> > then the script will error out with an error of:
> >
> > /tmp/.colorlsXXX: File exists.
> >
> > Cause:
> >
> > The script creates that temporary file with mktemp, but on the first
> > write it uses only a single redirect (>), which fails when noclobber is set.
> >
> > Since the file is already created, I think we can safely use an append
> > redirect (>>) in all cases where that file is written to, which works
> > regardless of the state of the noclobber settting.
> >
> > Patch:
> >
> > 35c35
> > < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> > ---
> > > if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP
> 
> The file 'colorls.csh' is not part of the upstream project
> but rather an Fedora extension.  I'm therefore marking this bug
> as 'done'.
> 
> It seems this particular issue has been fixed for F20 only:
> http://pkgs.fedoraproject.org/cgit/coreutils.git/commit/?id=f0b6f85aff0496c51c8fcb58197a8a132949a4e5
> 
> @Ondrej: do you plan to merge this to F19?

It was fixed only partially, direct redirection in the part mentioned by
Ty! still existed even in the rawhide trees. 
We don't do update for such minor issues in released Fedoras, but it
will be included in next cumulative F19 coreutils update, where I
usually merge all fixes from Fedora Rawhide from time to time.

Greetings,
          Ondrej

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.