GNU bug report logs - #15818
src/dfa.c: *MALLOC comment block: Clarify comment wording

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15818 in the body.
You can then email your comments to 15818 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: behoffski <behoffski <at> grouse.com.au>
To: bug-grep <at> gnu.org
Subject: src/dfa.c: *MALLOC comment block: Clarify comment wording
Date: Wed, 06 Nov 2013 13:50:28 +1030

[Message part 1 (text/plain, inline)]

G'day,

Attached is a patch clarifying the wording in a comment block in
dfa.c, relating to the XNMALLOC/XCALLOC/CALLOC/MALLOC/REALLOC
preprocessor function definitions.  Change is in comment text only;
no functional changes.

cheers,

behoffski (Brenton Hoff)
Programmer, Grouse Software

[x-alloc.patch (text/x-diff, attachment)]

Message #8 received at 15818 <at> debbugs.gnu.org (full text, mbox):

From: behoffski <behoffski <at> grouse.com.au>
To: 15818 <at> debbugs.gnu.org
Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment
 wording
Date: Thu, 26 Dec 2013 12:13:34 +1030

On 11/06/13 13:50, behoffski wrote:
> G'day,
>
> Attached is a patch clarifying the wording in a comment block in
> dfa.c, relating to the XNMALLOC/XCALLOC/CALLOC/MALLOC/REALLOC
> preprocessor function definitions.  Change is in comment text only;
> no functional changes.
>
> cheers,
>
> behoffski (Brenton Hoff)
> Programmer, Grouse Software

(Patch text included inline here:)
------------------
diff --git a/src/dfa.c b/src/dfa.c
index 92c410e..2063e90 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -433,7 +433,7 @@ static void dfamust (struct dfa *dfa);
 static void regexp (void);

 /* These two macros are identical to the ones in gnulib's xalloc.h,
-   except that they not to case the result to "(t *)", and thus may
+   except that they don't cast the result to "(t *)", and thus may
    be used via type-free CALLOC and MALLOC macros.  */
 #undef XNMALLOC
 #undef XCALLOC
------------------

Just a reminder that I've had no feedback on this bug, and it's small
enough to be included in the upcoming 2.15 release.  A number of
factors in my life have been really berserk recently (including
requiring a total work machine rebuild, still partially in progress),
so I haven't checked that the patch line numbering is still valid.

cheers,

behoffski (Brenton Hoff)
Programmer, Grouse Software

Message #13 received at 15818-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: behoffski <behoffski <at> grouse.com.au>
Cc: 15818-done <at> debbugs.gnu.org
Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment
 wording
Date: Wed, 25 Dec 2013 18:03:25 -0800

Thanks for the reminder.
Here's the commit I've created for you, along with a similarly trivial
one I spotted recently.
Please confirm that the USER NAME and <email address> I used in your
commit are ok.
In any future patches, please submit the output of "git format-patch
...", including a log message, per guidelines in HACKING.

Message #16 received at 15818-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: behoffski <behoffski <at> grouse.com.au>
Cc: 15818-done <15818-done <at> debbugs.gnu.org>
Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment
 wording
Date: Wed, 25 Dec 2013 18:04:27 -0800

[Message part 1 (text/plain, inline)]

Patch attached, this time:

[k.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.