GNU bug report logs - #15516
24.3; secrets.el `secrets-create-collection' is broken (fix included)

Previous Next

Package: emacs;

Reported by: Nicolas Petton <petton.nicolas <at> gmail.com>

Date: Thu, 3 Oct 2013 20:29:01 UTC

Severity: normal

Merged with 15519

Found in version 24.3

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15516 in the body.
You can then email your comments to 15516 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#15516; Package emacs. (Thu, 03 Oct 2013 20:29:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Petton <petton.nicolas <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 03 Oct 2013 20:29:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <petton.nicolas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; secrets.el `secrets-create-collection' is broken (fix included)
Date: Wed, 02 Oct 2013 19:12:31 +0200
In secrets.el, secrets-create-collection is broken (the DBus message
signature is wrong and the collection label is not the right one).

Here's a fixed version of the function:

(defun secrets-create-collection (collection)
  "Create collection labeled COLLECTION if it doesn't exist.
Return the D-Bus object path for collection."
  (let ((collection-path (secrets-collection-path collection)))
    ;; Create the collection.
    (when (secrets-empty-path collection-path)
      (setq collection-path
	    (secrets-prompt
	     (cadr
	      ;; "CreateCollection" returns the prompt path as second arg.
	      (dbus-call-method
	       :session secrets-service secrets-path
	       secrets-interface-service "CreateCollection"
	       `(:array 
		 (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection)))
	       "")))))
    ;; Return object path of the collection.
    collection-path))




Merged 15516 15519. Request was from Michael Albinus <michael.albinus <at> gmx.de> to control <at> debbugs.gnu.org. (Fri, 04 Oct 2013 09:38:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#15516; Package emacs. (Fri, 04 Oct 2013 10:37:01 GMT) Full text and rfc822 format available.

Message #10 received at 15516 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Nicolas Petton <petton.nicolas <at> gmail.com>
Cc: 15516 <at> debbugs.gnu.org
Subject: Re: bug#15516: 24.3;
 secrets.el `secrets-create-collection' is broken (fix included)
Date: Fri, 04 Oct 2013 12:36:22 +0200
Nicolas Petton <petton.nicolas <at> gmail.com> writes:

Hi Nicolas,

> In secrets.el, secrets-create-collection is broken (the DBus message
> signature is wrong and the collection label is not the right one).

Thanks for the report. I have applied a slightly different patch to the
Emacs repository. Please check
<http://bzr.savannah.gnu.org/lh/emacs/trunk/download/head:/secrets.el-20100313201810-6s62gy70hbdnhfs1-1/secrets.el>.

Best regards, Michael.




bug marked as fixed in version 24.4, send any further explanations to 15516 <at> debbugs.gnu.org and Nicolas Petton <petton.nicolas <at> gmail.com> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 07 Oct 2013 00:34:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 04 Nov 2013 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 11 years and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.