GNU bug report logs - #15516
24.3; secrets.el `secrets-create-collection' is broken (fix included)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15516 in the body.
You can then email your comments to 15516 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <petton.nicolas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; secrets.el `secrets-create-collection' is broken (fix included)
Date: Wed, 02 Oct 2013 19:12:31 +0200

In secrets.el, secrets-create-collection is broken (the DBus message
signature is wrong and the collection label is not the right one).

Here's a fixed version of the function:

(defun secrets-create-collection (collection)
  "Create collection labeled COLLECTION if it doesn't exist.
Return the D-Bus object path for collection."
  (let ((collection-path (secrets-collection-path collection)))
    ;; Create the collection.
    (when (secrets-empty-path collection-path)
      (setq collection-path
	    (secrets-prompt
	     (cadr
	      ;; "CreateCollection" returns the prompt path as second arg.
	      (dbus-call-method
	       :session secrets-service secrets-path
	       secrets-interface-service "CreateCollection"
	       `(:array 
		 (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection)))
	       "")))))
    ;; Return object path of the collection.
    collection-path))

Message #10 received at 15516 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Nicolas Petton <petton.nicolas <at> gmail.com>
Cc: 15516 <at> debbugs.gnu.org
Subject: Re: bug#15516: 24.3;
 secrets.el `secrets-create-collection' is broken (fix included)
Date: Fri, 04 Oct 2013 12:36:22 +0200

Nicolas Petton <petton.nicolas <at> gmail.com> writes:

Hi Nicolas,

> In secrets.el, secrets-create-collection is broken (the DBus message
> signature is wrong and the collection label is not the right one).

Thanks for the report. I have applied a slightly different patch to the
Emacs repository. Please check
<http://bzr.savannah.gnu.org/lh/emacs/trunk/download/head:/secrets.el-20100313201810-6s62gy70hbdnhfs1-1/secrets.el>.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.