GNU bug report logs - #15408
23.4; icalendar import: daylight saving time

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15408 in the body.
You can then email your comments to 15408 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christophe Deleuze <christophe.deleuze <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.4; icalendar import: daylight saving time
Date: Wed, 18 Sep 2013 14:54:01 +0200

[Message part 1 (text/plain, inline)]

[This is a small bug in icalendar.el.  A simple fix is provided.
Although tested on version 23.4, I checked the file icalendar.el hasn't
changed in current developpement version (downloaded for bazaar
repository on Sep 4th).]

* bug description

When importing an ics file into a diary file, date/times are not always
correctly converted from UTC to local time zone.

Example: let's import the provided mini.ics icalendar file, where
dates are in UTC (trailing 'Z'), on a system using the Europe/Paris
time zone.  This time zone has a time 2 hours ahead of UTC during
daylight saving and 1 hour ahead otherwise.

The file contains two events, the first one is planned on november 12
2013, from 12:15 to 14:00 UTC, the second one is planned on september
12 2013, from 8:00 to 9:45 UTC.

september 12 2013 is in daylight saving time period, while december 11
2013 is not.  The generated diary file (provided as mini.diary) shows
a 2 hours offset has been added to both events, while it should have
added a single hour offset to the second one.  It has been generated
on september 7 2013, during daylight saving time period.  Please note
that my emacs uses the european date display style, so that september
12 2013 is written as 12/9/2013 in the diary file.

* fix description

The function icalendar--decode-isodatetime in calendar/icalendar.el
calls (current-time-zone) to add current time zone offset when the ics
time is UTC.  However, the function is called without argument,
meaning the returned offset is the one applying at the time of
calling.

It should be called with the (UTC) date/time of the converted
date/time so that computed offset is the one in force at that precise
date/time.

The patch file icalendar.patch fixes the problem.  File
mini.diary-patched is the result of importing mini.ics with the
patched icalendar.el file.

* changelog

Small change in icalendar--decode-isodatetime.

[mini.ics (text/calendar, attachment)]

[mini.diary (text/plain, attachment)]

[mini.diary-patched (text/plain, attachment)]

[icalendar.patch (text/x-diff, attachment)]

Message #8 received at 15408 <at> debbugs.gnu.org (full text, mbox):

From: Ulf Jasper <ulf.jasper <at> web.de>
To: Christophe Deleuze <christophe.deleuze <at> free.fr>
Cc: 15408 <at> debbugs.gnu.org, 15408-done <at> debbugs.gnu.org
Subject: Re: bug#15408: 23.4; icalendar import: daylight saving time
Date: Wed, 30 Jul 2014 18:33:03 +0200

Christophe Deleuze <christophe.deleuze <at> free.fr> writes:

> [This is a small bug in icalendar.el.  A simple fix is provided.

I applied your patch to the trunk (and added a unit test), rev. 117612.

Thank you very much!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.