GNU bug report logs - #15235
24.3.50; package.el updates load-path too late

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15235: closed (24.3.50; package.el updates load-path too late)
Date: Thu, 02 Jun 2016 17:10:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 2 Jun 2016 13:09:19 -0400
with message-id <CAM-tV-_Fx+VCnfe4=4oevBgVJOJVunzEVw3cMwx=o+e_DNrKTg <at> mail.gmail.com>
and subject line Re: bug#15235: 24.3.50; package.el updates load-path too late
has caused the debbugs.gnu.org bug report #15235,
regarding 24.3.50; package.el updates load-path too late
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15235
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Richard Kim <emacs18 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; package.el updates load-path too late
Date: Sun, 01 Sep 2013 09:45:53 -0700

A recent change made on bzr trunk is causing one of my ELPA packages to
fail to load due to `load-path' not being updated promptly.

The change in question seems to be Stefan's revision 114047 checked in
on Aug 28, 2013 with check in comment

    Don't add unnecessarily to load-path.

The package in question is icicles which I created by putting together a
few files from emacswiki.org which I have been using for several years.

The problem is that icicles-autoloads.el refers to some custom face
which is provided by icicles-face.el in the icicles package directory.
However Stefan's change now evaluates icicles-autoloads.el first then
updates load-path to add path for icicles.  Following shows
`package-activate-1' from around August 24:

    (defun package-activate-1 (pkg-desc)
      (let* ((name (package-desc-name pkg-desc))
    	 (pkg-dir (package-desc-dir pkg-desc)))
        (unless pkg-dir
          (error "Internal error: unable to find directory for `%s'"
    	     (package-desc-full-name pkg-desc)))
        ;; Add info node.
        (when (file-exists-p (expand-file-name "dir" pkg-dir))
          ;; FIXME: not the friendliest, but simple.
          (require 'info)
          (info-initialize)
          (push pkg-dir Info-directory-list))
        ;; Add to load path, add autoloads, and activate the package.
        (push pkg-dir load-path)
        (load (expand-file-name (format "%s-autoloads" name) pkg-dir) nil t)
        (push name package-activated-list)
        ;; Don't return nil.
        t))

Note that (load) of the "-autolads" file comes after updating of
load-path, i.e., (push pkg-dir load-path).  Thus icicles-face.el can be
found in this version of package.el.

Shouldn't load-path updated first for the packge being intialized so
that code in "*-autoloads.el" can load other elisp files in the package
directory?

[Message part 3 (message/rfc822, inline)]

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 15235-done <at> debbugs.gnu.org
Subject: Re: bug#15235: 24.3.50; package.el updates load-path too late
Date: Thu, 2 Jun 2016 13:09:19 -0400

Closing since everyone using 24.3.50 must have updated their
*-autoloads.el files by now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.