GNU bug report logs - #15235
24.3.50; package.el updates load-path too late

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15235 in the body.
You can then email your comments to 15235 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Kim <emacs18 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; package.el updates load-path too late
Date: Sun, 01 Sep 2013 09:45:53 -0700

A recent change made on bzr trunk is causing one of my ELPA packages to
fail to load due to `load-path' not being updated promptly.

The change in question seems to be Stefan's revision 114047 checked in
on Aug 28, 2013 with check in comment

    Don't add unnecessarily to load-path.

The package in question is icicles which I created by putting together a
few files from emacswiki.org which I have been using for several years.

The problem is that icicles-autoloads.el refers to some custom face
which is provided by icicles-face.el in the icicles package directory.
However Stefan's change now evaluates icicles-autoloads.el first then
updates load-path to add path for icicles.  Following shows
`package-activate-1' from around August 24:

    (defun package-activate-1 (pkg-desc)
      (let* ((name (package-desc-name pkg-desc))
    	 (pkg-dir (package-desc-dir pkg-desc)))
        (unless pkg-dir
          (error "Internal error: unable to find directory for `%s'"
    	     (package-desc-full-name pkg-desc)))
        ;; Add info node.
        (when (file-exists-p (expand-file-name "dir" pkg-dir))
          ;; FIXME: not the friendliest, but simple.
          (require 'info)
          (info-initialize)
          (push pkg-dir Info-directory-list))
        ;; Add to load path, add autoloads, and activate the package.
        (push pkg-dir load-path)
        (load (expand-file-name (format "%s-autoloads" name) pkg-dir) nil t)
        (push name package-activated-list)
        ;; Don't return nil.
        t))

Note that (load) of the "-autolads" file comes after updating of
load-path, i.e., (push pkg-dir load-path).  Thus icicles-face.el can be
found in this version of package.el.

Shouldn't load-path updated first for the packge being intialized so
that code in "*-autoloads.el" can load other elisp files in the package
directory?

Message #8 received at 15235 <at> debbugs.gnu.org (full text, mbox):

From: Richard Kim <emacs18 <at> gmail.com>
To: 15235 <at> debbugs.gnu.org
Subject: Re: bug#15235: Acknowledgement (24.3.50; package.el updates load-path
 too late)
Date: Sun, 1 Sep 2013 15:45:11 -0700

[Message part 1 (text/plain, inline)]

After looking into this further, I learned that reinstalling packages adds
code in *-autoloads.el file to set load-path.

So my problem was resolved by reinstalling all my private ELPA packages.

As far as I'm concerned, this is no longer a bug.
However it looks like recent change in package.el requires everyone to
reinstall all their packages!



On 1 September 2013 09:47, GNU bug Tracking System <help-debbugs <at> gnu.org>wrote:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  bug-gnu-emacs <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 15235 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 15235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15235
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems
>

[Message part 2 (text/html, inline)]

Message #11 received at 15235 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Richard Kim <emacs18 <at> gmail.com>
Cc: 15235 <at> debbugs.gnu.org
Subject: Re: bug#15235: 24.3.50; package.el updates load-path too late
Date: Mon, 02 Sep 2013 21:50:34 -0400

> Shouldn't load-path updated first for the packge being intialized so
> that code in "*-autoloads.el" can load other elisp files in the package
> directory?

Actually, "nowadays" the *-autoloads.el file should begin by adding to
load-path so package.el doesn't need to do it any more.


        Stefan

Message #14 received at 15235 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Richard Kim <emacs18 <at> gmail.com>
Cc: 15235 <at> debbugs.gnu.org
Subject: Re: bug#15235: Acknowledgement (24.3.50;
 package.el updates load-path too late)
Date: Mon, 02 Sep 2013 22:16:07 -0400

> However it looks like recent change in package.el requires everyone to
> reinstall all their packages!

Not really: normally the *-autoloads.el file does not require loading
any other file.


        Stefan

Message #21 received at 15235-done <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 15235-done <at> debbugs.gnu.org
Subject: Re: bug#15235: 24.3.50; package.el updates load-path too late
Date: Thu, 2 Jun 2016 13:09:19 -0400

Closing since everyone using 24.3.50 must have updated their
*-autoloads.el files by now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.