GNU bug report logs - #15009
cl-lib symbols in lisp-font-lock-keywords

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15009 in the body.
You can then email your comments to 15009 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: cl-lib symbols in lisp-font-lock-keywords
Date: Fri, 2 Aug 2013 18:31:57 +0200

Package: emacs
Version: 24.3.50

Now that cl-lib is the preferred way to use CL, cl-lib symbols like
cl-defun, cl-loop. cl-defstruct, etc.
should be added to lisp-font-lock-keywords-*.

Message #8 received at 15009 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 15009 <at> debbugs.gnu.org
Subject: Re: bug#15009: cl-lib symbols in lisp-font-lock-keywords
Date: Fri, 02 Aug 2013 12:40:50 -0400

Dupe of http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12761

Message #13 received at 15009 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 15009 <at> debbugs.gnu.org
Subject: Re: bug#15009: cl-lib symbols in lisp-font-lock-keywords
Date: Fri, 02 Aug 2013 13:16:25 -0400

> Now that cl-lib is the preferred way to use CL, cl-lib symbols like
> cl-defun, cl-loop. cl-defstruct, etc.
> should be added to lisp-font-lock-keywords-*.

Right.

But: these are not valid in Lisp.  So we need to clean this up by
splitting lisp-font-lock-keywords into a "Lisp" part and an
"Elisp" part.

BTW, ideally, these keyword faces would be added by dynamically
collecting the set of known macros, rather than by a hardcoded list.


        Stefan

Message #16 received at 15009 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 15009 <at> debbugs.gnu.org
Subject: Re: bug#15009: cl-lib symbols in lisp-font-lock-keywords
Date: Fri, 2 Aug 2013 19:26:39 +0200

On Fri, Aug 2, 2013 at 7:16 PM, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> But: these are not valid in Lisp.  So we need to clean this up by
> splitting lisp-font-lock-keywords into a "Lisp" part and an
> "Elisp" part.

OK.

> BTW, ideally, these keyword faces would be added by dynamically
> collecting the set of known macros, rather than by a hardcoded list.

Why? It is a restricted and well-defined set, unlikely to change.
Adding them dynamically adds unnecessary complexity IMO.

   J

Message #19 received at 15009 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 15009 <at> debbugs.gnu.org
Subject: Re: bug#15009: cl-lib symbols in lisp-font-lock-keywords
Date: Fri, 02 Aug 2013 15:23:15 -0400

>> BTW, ideally, these keyword faces would be added by dynamically
>> collecting the set of known macros, rather than by a hardcoded list.
> Why? It is a restricted and well-defined set, unlikely to change.
> Adding them dynamically adds unnecessary complexity IMO.

In order to highlight the name of things defined with cl-defun and
friends, I agree.  But the part that highlights `cl-destructuring-bind'
in font-lock-keyword-face should do it based on the fact that
cl-destructuring-bind is a macro, not via some hard-coded list.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.