GNU bug report logs - #14975
24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleh <o.krehel <at> tue.nl>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Sun, 28 Jul 2013 15:49:00 +0200

[Message part 1 (text/plain, inline)]

Currently, this function behaves unconditionally
as if `org-clock-sound' was set to t.

I attach a patch of how I fixed it for my needs:

[0001-org-clock.el-org-clock-notify-once-if-expired-respec.patch (text/x-diff, inline)]

From db2cc63bbdd4e51bd7a150186b131a39d7d10a6e Mon Sep 17 00:00:00 2001
From: oleh <wave <at> mail.ua>
Date: Sun, 28 Jul 2013 15:39:57 +0200
Subject: [PATCH] org-clock.el: `org-clock-notify-once-if-expired' respects
 `org-clock-sound'.

---
 lisp/org-clock.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 8ac215e..99479b2 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -718,7 +718,7 @@ Notification is shown only once."
 	    (setq org-clock-notification-was-shown t)
 	    (org-notify
 	     (format "Task '%s' should be finished by now. (%s)"
-		     org-clock-heading org-clock-effort) t))
+		     org-clock-heading org-clock-effort) org-clock-sound))
 	(setq org-clock-notification-was-shown nil)))))
 
 (defun org-notify (notification &optional play-sound)
-- 
1.8.1.2

[Message part 3 (text/plain, inline)]

regards,
Oleh

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.