GNU bug report logs - #14975
24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14975 in the body.
You can then email your comments to 14975 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleh <o.krehel <at> tue.nl>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Sun, 28 Jul 2013 15:49:00 +0200

[Message part 1 (text/plain, inline)]

Currently, this function behaves unconditionally
as if `org-clock-sound' was set to t.

I attach a patch of how I fixed it for my needs:

[0001-org-clock.el-org-clock-notify-once-if-expired-respec.patch (text/x-diff, inline)]

From db2cc63bbdd4e51bd7a150186b131a39d7d10a6e Mon Sep 17 00:00:00 2001
From: oleh <wave <at> mail.ua>
Date: Sun, 28 Jul 2013 15:39:57 +0200
Subject: [PATCH] org-clock.el: `org-clock-notify-once-if-expired' respects
 `org-clock-sound'.

---
 lisp/org-clock.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 8ac215e..99479b2 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -718,7 +718,7 @@ Notification is shown only once."
 	    (setq org-clock-notification-was-shown t)
 	    (org-notify
 	     (format "Task '%s' should be finished by now. (%s)"
-		     org-clock-heading org-clock-effort) t))
+		     org-clock-heading org-clock-effort) org-clock-sound))
 	(setq org-clock-notification-was-shown nil)))))
 
 (defun org-notify (notification &optional play-sound)
-- 
1.8.1.2

[Message part 3 (text/plain, inline)]

regards,
Oleh

Message #10 received at 14975-done <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Oleh <o.krehel <at> tue.nl>
Cc: 14975-done <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 12:46:50 +0200

Hi Oleh,

Oleh <o.krehel <at> tue.nl> writes:

> Currently, this function behaves unconditionally
> as if `org-clock-sound' was set to t.
>
> I attach a patch of how I fixed it for my needs:

Please send those patches to the org-mode list first.

I applied it but added a ChangeLog entry in the commit message
and the TINYCHANGE change cookie that helps us track small changes
by contributors who did not assign their copyright to the FSF (yet).

Thanks for catching this,

-- 
 Bastien

Message #13 received at 14975-done <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Oleh <o.krehel <at> tue.nl>
Cc: 14975-done <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 12:50:41 +0200

Bastien <bzg <at> altern.org> writes:

> Please send those patches to the org-mode list first.

PS: Maybe it's just me and I did not see the initial bug
report on this list -- ignore the heads up if that's so!

-- 
 Bastien

Message #16 received at 14975 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Bastien <bzg <at> gnu.org>
Cc: 14975 <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 11:53:35 -0400

Bastien wrote:

>> Please send those patches to the org-mode list first.
>
> PS: Maybe it's just me and I did not see the initial bug
> report on this list -- ignore the heads up if that's so!

If by "this list" you mean the org-mode list:
It was initially reported to bug-gnu-emacs. Then I assigned it to the
"emacs,org-mode" package, so that subsequent emails went to the org-mode
list as well as the bug-gnu-emacs list. This would have happened with
the initial report if it had specified a "Package: emacs,org-mode" line.
(Though there seems no point in having "emacs" in there really.)

Message #19 received at 14975 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14975 <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 19:22:55 +0200

Hi Glenn,

Glenn Morris <rgm <at> gnu.org> writes:

>>> Please send those patches to the org-mode list first.
>>
>> PS: Maybe it's just me and I did not see the initial bug
>> report on this list -- ignore the heads up if that's so!
>
> If by "this list" you mean the org-mode list:
> It was initially reported to bug-gnu-emacs. Then I assigned it to the
> "emacs,org-mode" package, so that subsequent emails went to the org-mode
> list as well as the bug-gnu-emacs list. This would have happened with
> the initial report if it had specified a "Package: emacs,org-mode" line.
> (Though there seems no point in having "emacs" in there really.)

Thanks for the explanations.

This is what I expected, but I don't find the bug in the org-mode
mailing list.  The only reference I can find is my reply:
http://lists.gnu.org/archive/html/emacs-orgmode/2013-07/msg01094.html

Does anyone receive this bug on the first place?  Or someone can
browse the archives better than me?

-- 
 Bastien

Message #22 received at 14975 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Bastien <bzg <at> altern.org>
Cc: 14975 <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 13:27:48 -0400

Bastien wrote:

>> It was initially reported to bug-gnu-emacs. Then I assigned it to the
>> "emacs,org-mode" package, so that subsequent emails went to the org-mode
>> list as well as the bug-gnu-emacs list. This would have happened with
>> the initial report if it had specified a "Package: emacs,org-mode" line.
>> (Though there seems no point in having "emacs" in there really.)
>
> Thanks for the explanations.
>
> This is what I expected, but I don't find the bug in the org-mode
> mailing list.

That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
list is coupled to debbugs.gnu.org, and because I reassigned the bug
after it was received, subsequent replies went to both lists. But the
initial report is only on bug-gnu-emacs.

Message #25 received at 14975 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Bastien <bzg <at> altern.org>, 14975 <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 14:24:54 -0400

> That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
> list is coupled to debbugs.gnu.org, and because I reassigned the bug
> after it was received, subsequent replies went to both lists. But the
> initial report is only on bug-gnu-emacs.

It would be nice if some message were sent to org-mode's list when
`org-mode' is added to the "Package:" list.


        Stefan "applicable to other packages than org-mode, obviously"

Message #28 received at 14975 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14975 <at> debbugs.gnu.org
Subject: Re: bug#14975: 24.3;
 org-mode's `org-clock-notify-once-if-expired' doesn't respect
 `org-clock-sound'
Date: Tue, 30 Jul 2013 22:54:15 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> That's what I'm saying. It was sent to bug-gnu-emacs ONLY. Because that
> list is coupled to debbugs.gnu.org, and because I reassigned the bug
> after it was received, subsequent replies went to both lists. But the
> initial report is only on bug-gnu-emacs.

Got it now, thanks!

-- 
 Bastien, who agrees with Stefan's suggestion on this

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.